From: Mike Frysinger <vapier.adi@gmail.com>
To: Chris Verges <chrisv@cyberswitching.com>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
uclinux-dist-devel@blackfin.uclinux.org,
Luotao Fu <l.fu@pengutronix.de>,
Michael Hennerich <michael.hennerich@analog.com>,
Barry Song <barry.song@analog.com>
Subject: Re: [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346 driver
Date: Tue, 20 Oct 2009 22:32:29 -0400 [thread overview]
Message-ID: <8bd0f97a0910201932l1fc83412g8c3385920eae6aa0@mail.gmail.com> (raw)
In-Reply-To: <68FBE0F3CE97264395875AC1C468F22C1CA0D8@mail03.cyberswitching.local>
On Tue, Oct 20, 2009 at 14:46, Chris Verges wrote:
> Hi Mike and Michael,
>
>>+config INPUT_ADXL34X
>>+config INPUT_ADXL34X_I2C
>>+config INPUT_ADXL34X_SPI
>
> Should the INPUT_ADXL34X option be auto-selected when the _I2C or _SPI
> counterparts are selected? Something like:
>
> config HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X
> depends on HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X_I2C
> bool "..."
> depends on I2C
> select HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X_SPI
> bool "..."
> depends on SPI_MASTER
> select HAVE_INPUT_ADXL34X
>
> The end user would only see the INPUT_ADXL34X_SPI and INPUT_ADXL34X_I2C
> options, with the common INPUT_ADXL34X option being automagically
> selected due to the reverse dependencies.
while it should work nicely if we only dealt with bools, dealing with
tristates (and thus allowing the driver to be a module) doesnt work
cleanly.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-21 2:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 10:27 [PATCH] input/misc: new ADXL345/346 driver Mike Frysinger
[not found] ` <1255516029-30023-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-10-14 10:54 ` [PATCH v2] " Mike Frysinger
2009-10-16 4:36 ` Dmitry Torokhov
[not found] ` <20091016043627.GC11582-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-10-16 5:39 ` Mike Frysinger
[not found] ` <8bd0f97a0910152239v3c889a95rd9b100e3e7204e98-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-16 5:44 ` Dmitry Torokhov
[not found] ` <20091016054414.GE11582-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-10-16 5:53 ` Mike Frysinger
2009-10-16 6:57 ` [Uclinux-dist-devel] " Mike Frysinger
2009-10-16 7:22 ` Dmitry Torokhov
[not found] ` <20091016072216.GH11582-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-10-16 8:20 ` Mike Frysinger
2009-10-16 9:06 ` Hennerich, Michael
2009-10-20 8:40 ` [PATCH v3] " Mike Frysinger
2009-10-20 18:46 ` Chris Verges
2009-10-21 2:32 ` Mike Frysinger [this message]
2010-06-25 7:14 ` Dmitry Torokhov
[not found] ` <20100625071425.GA631-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-06-25 13:59 ` Hennerich, Michael
2010-07-01 7:53 ` Dmitry Torokhov
2010-07-01 9:15 ` Hennerich, Michael
2010-07-01 16:08 ` Dmitry Torokhov
2010-07-21 13:50 ` [Uclinux-dist-devel] " Mike Frysinger
2010-07-23 6:44 ` Dmitry Torokhov
2010-08-05 12:30 ` Hennerich, Michael
2010-08-06 5:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0910201932l1fc83412g8c3385920eae6aa0@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=barry.song@analog.com \
--cc=chrisv@cyberswitching.com \
--cc=dmitry.torokhov@gmail.com \
--cc=l.fu@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).