Re: [git pull] Input updates for 2.6.34-rc0

[Mike Frysinger <vapier.adi@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On Mon, Mar 22, 2010 at 02:37, Dmitry Torokhov wrote:
> On Tue, Mar 09, 2010 at 01:13:34PM -0500, Mike Frysinger wrote:
>> On Tue, Mar 9, 2010 at 13:10, Dmitry Torokhov wrote:
>> > On Tue, Mar 09, 2010 at 12:58:24PM -0500, Mike Frysinger wrote:
>> >> the AD714x is not an accelerometer, it's a capacitance touch sensor
>> >
>> > OK, will dig it up.
>>
>> thanks
>
> Mike, could you please take a look at mny 'next' branch and give the
> version there a try - I made a couple of small changes before
> applying...

changes look ok to me, and it seems to build fine.  maybe Barry can
give it a quick test to make sure it still probes/works, but i dont
see anything to suggest it wouldnt ...

if you're doing cosmetic fixes, i'd suggest squashing the attached into it too.
-mike

[-- Attachment #2: ad714x-comments.patch --]
[-- Type: application/octet-stream, Size: 1267 bytes --]

diff --git a/drivers/input/misc/ad714x.c b/drivers/input/misc/ad714x.c
index ed6381a..f8c4e45 100644
--- a/drivers/input/misc/ad714x.c
+++ b/drivers/input/misc/ad714x.c
@@ -234,7 +234,6 @@ static int ad714x_cal_abs_pos(struct ad714x_chip *ad714x,
 	return (max_coord / (end_stage - start_stage)) * a_param / b_param;
 }
 
-
 /*
  * One button can connect to multi positive and negative of CDCs
  * Multi-buttons can connect to same positive/negative of one CDC
@@ -426,7 +425,8 @@ static void ad714x_slider_state_machine(struct ad714x_chip *ad714x, int idx)
 	}
 }
 
-/* When the scroll wheel is activated, we compute the absolute position based
+/*
+ * When the scroll wheel is activated, we compute the absolute position based
  * on the sensor values. To calculate the position, we first determine the
  * sensor that has the greatest response among the 8 sensors that constitutes
  * the scrollwheel. Then we determined the 2 sensors on either sides of the
@@ -1005,7 +1005,7 @@ static void ad714x_hw_init(struct ad714x_chip *ad714x)
 	unsigned short reg_base;
 	unsigned short data;
 
-	/* configuration CDC and interrupts*/
+	/* configuration CDC and interrupts */
 
 	for (i = 0; i < STAGE_NUM; i++) {
 		reg_base = AD714X_STAGECFG_REG + i * STAGE_CFGREG_NUM;