From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76193C4332F for ; Thu, 13 Oct 2022 12:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbiJMMc4 (ORCPT ); Thu, 13 Oct 2022 08:32:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiJMMcz (ORCPT ); Thu, 13 Oct 2022 08:32:55 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28A2411B2E6 for ; Thu, 13 Oct 2022 05:32:54 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id s3so845732qtn.12 for ; Thu, 13 Oct 2022 05:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K9/tYfzo17fxLFOcvb7w4ZSv+9JYtZRmBZDcx1r51RQ=; b=T8PR2tbP2asBfPQ/sPK7BXRCjTnXv7MbrGu6XACJj7n5bOLtJO1scp5X5Pg95HDtSU LX88dulxsHzuUS4qhA7+Rk92DSgMWUUTpWwkyW9z65GjqHJYQRvieFZtzR+alSdsB/ME 1Lu6Bd9vx5A/i258W++UPk1L14KM6AMWkbV0cOl5PCb8hpJRJ0sd2DNs5nPjgWlujXrE 8PisCB6Ot2YFWI5w1XCs5tKHe4cbyNvZSSnDjFnRxJiFH1iYcJjtUvtRiP4mEBl3R/vB L7PvSM3x7yzClY80o9bvSqf/tOpc4kz2QTJCvL0DZFoDQbzKQ2nDKRUyti8Z6XVeKrXZ 7+6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K9/tYfzo17fxLFOcvb7w4ZSv+9JYtZRmBZDcx1r51RQ=; b=YKV8BHaWVrdI261TTrUQXFD6lZpEReKZj6WyA0ShwIlyCfS78gBvlTynPdv/kLIXXL 3DNSF4mThHdocCXtvmm67+kSUVj72y1UiYYvmb6AeQs1A1oGOcski4KrK5twMeakPN55 TSDRmvK5INlLsP/9AVKhZWUKuOZROpGiupw2tn5KIlCK8WjdCJNKs0eBw5hVNcxbnlVK 8AzxWoUWnBhiP/AjVgquC9U8rop1viTYdecXTu3re3N3xSGsA5smYLPmCxKbjsC1FxgD LzMkQ7asWU95MwWy3CATvoytJvME4z7BxsM03UeT7OMrwcKGeh/7OwMbH6MXcA8tvg9g pNRA== X-Gm-Message-State: ACrzQf03scI3DqTYuBZKj9zIjSBLp0yGHW2/3+GfQQ/9ikZnQ7B6nM8V 5Mg3ljDoxUFF51hcIILhUm1SOw== X-Google-Smtp-Source: AMsMyM6odUD07MJbJEAOtrPomHyrhKE2DOIYANh7IOcMSsMD88ZCbgJDBPZ1duhCai51wYvDAvDioA== X-Received: by 2002:a05:622a:546:b0:393:7334:65de with SMTP id m6-20020a05622a054600b00393733465demr27887490qtx.504.1665664373240; Thu, 13 Oct 2022 05:32:53 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id k11-20020a05620a0b8b00b006cbc6e1478csm17498265qkh.57.2022.10.13.05.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Oct 2022 05:32:52 -0700 (PDT) Message-ID: <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org> Date: Thu, 13 Oct 2022 08:32:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: Kevin Hilman , jerome Neanne , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> <7hzge1hqof.fsf@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <7hzge1hqof.fsf@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 12/10/2022 13:56, Kevin Hilman wrote: > Krzysztof Kozlowski writes: > >> On 12/10/2022 04:39, jerome Neanne wrote: >>>> You explained what you did, which is easily visible. You did not explain >>>> why you are doing it. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> Thanks for pointing me to the detailed guidelines >>> I'm new to upstream and not well aware of all good practices. >>> >>> Would below commit message be more suitable: >>> >>> Add support for the TPS65219 PMIC by enabling MFD, regulator and >>> power-button drivers. All drivers enabled as modules. >> >> This still says only what you did. I still does not explain why. > > Jerome, maybe adding a bit of preamble like: > > "Development boards from TI include the TPS65219 PMIC. Add support..." I would propose: "Development boards from TI with xxx SoC include the ..." because the point is that you use this defconfig for boards for given SoC (supported by upstream). Other way would be "Foo-bar development board includes the TP..." > > Krzysztof, I'm the first to argue for descriptive/verbose changelogs, > but IMO, this is getting a little bit nit-picky. > > The series adds a new driver, DTS and defconfig patches to enable > support the new driver. The "why" for changes to defconfig changes like > this are kind of implied/obvious, and there is lots of precedent for > changelogs of defconfig changes for simple drivers to simply say "enable > X and Y". While I understand the entire patchset, the defconfig goes via separate tree/branch and must stand on its own. Later (one month, one year, one decade) someone will look at history and wonder why the heck we enabled TPS65219. > > If my above suggesion is not enough, please make a suggestion for what > you think would qualify as an appropritate changelong that answers "why" > for a simple driver change. It is enough :) Best regards, Krzysztof