From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9754214813 for ; Mon, 29 Jun 2026 13:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740427; cv=none; b=O9R7RHIfyboVTnU8BpR+PR5RSnsPZEpgDHr6FARb4y9NEWITzR77x2buuEs3/UsGszvjzYwtBQTEYmfQ5SsqGDhPU81rE/BduaoqQSWz9mPHYYB89MlMwfh4sAqpz5Lbu/l3CjxmfRC2/xsDbSP6MYV1lWuNMCM2nzECIBjMn+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740427; c=relaxed/simple; bh=jQhPNikCLFX4aqzB4C1+S0WA2gryD4jcToyA0jONtOk=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=uiE4JfMzqXcX7jBEuXV9XS/twme/DM2GS6oj3rWKO8MFc/cJvdvOyWQmWJefSCse8gnyBrsZg6Du7XsU4OYOPJIUJTFFhK6+6zCbBCUuwNENlkyhUFKVm0CmBs78POpWnYajj6U/KI9RWyxKDgEZGe/3QcREYw+1kksRWkOa6kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oqDQdMo7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oqDQdMo7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 976AD1F000E9 for ; Mon, 29 Jun 2026 13:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782740426; bh=dWdlr26Kfs/ahO6K+kk8aoFsE4SSI5ytweuNJUqCaA4=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=oqDQdMo790z06ApeDSsvY3m+Y8IZ4VZoMJkJhGr7E/IjZKx64O22KSnF3+xUuRO3f yvH5ym4dczIjGKrdczIpYfPoLBBOcsxNrSj6h91hZ+c5LvwtiryvUwTame1uNn9Rrr WyUON5JVM6X2M7HXjlu9dCFHaih+ML2mRji8q5NmqYxEhmCp7jscP8v8CkZYNWd2dr xhd1FM87CLb5bUe65OvOAO6e+bbCfwR/aLNQ4BOFjJCR1+oo0E91peSLwfYNysxn6M wnQNp12CKUcvYWs6JX5HamOMDo/C2BRDOWvmsuEXyiewWafhXqE043sHdG1WMky78y KaEDaoyncHfiw== Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id D29C2F40082; Mon, 29 Jun 2026 09:40:25 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-04.internal (MEProxy); Mon, 29 Jun 2026 09:40:25 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTEwyiikSuk+z/VB2qVPcN1EQyPqA6WOQ+eFtbmbh6SYaSdz7rkBD37IEwyRDxtGET RORijbLfntwSPyFj2YhZEbxd60mXyZA33VmqxImL2DoUQeJH8Eez29TcwFZHYq7GR2yV8n jbsxVBlwdvYKEdKvg4ZKi13qW9ThkVZs47boS3WbARwM/E1OWlqRoBErtwtlNJ0R5Uqnf5 Ixe+uJJEcddGGI76MWMTE7QWmZJQ2j5h0IUaySJvyy84KFVeoRG+xobECdL/BEBMIBJvIT vvY6jpAUWxFgibIpez0dkLzhr8JwreXhzf6N1if0Mv2I7aoOfRViYHOgo9xDeKDSfmqrc0 iSlhQqoz6k6wqeTYy8PI8zx9YYZoGli25qI5RoAZ9tzJMdOUnNzoyCkLokZBZfjKqlbNqR 8j3uP77Efk1N4TXDZEWVo7BItO+J552OgM7xc6prSeMBikR6t2ddmjg+T6biUzS1XWSu4S 4PcVHPkg8tRLcS/eCNibn88VZvhoDLTuaWX7QXF0biINHZ+F3b9TfBXbIb4aPtOyxSdotP qbNmWSaBBWDJPeIdSBTMRv6j/08rtOZp8IH64RAJQZ+gZewcT/PCfpZ/bHKYrB18Hn+hCr Iv4R6tKJCY5qX7ooutrYvIU/31SA7G6i2L1cdcDk33vL2efgRtjoMq97UFkw X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id B0AEA1820082; Mon, 29 Jun 2026 09:40:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AwEGTrxsrqWN Date: Mon, 29 Jun 2026 15:40:04 +0200 From: "Arnd Bergmann" To: sashiko-reviews@lists.linux.dev Cc: linux-input@vger.kernel.org, "Lee Jones" , "Dmitry Torokhov" , linux-leds@vger.kernel.org Message-Id: <8dc0efb2-4e16-4fc8-943e-8043713ce2fa@app.fastmail.com> In-Reply-To: <20260629132505.A53EB1F000E9@smtp.kernel.org> References: <20260629130329.1291953-1-arnd@kernel.org> <20260629130329.1291953-3-arnd@kernel.org> <20260629132505.A53EB1F000E9@smtp.kernel.org> Subject: Re: [PATCH 2/6] [v5] x86/olpc: select GPIOLIB_LEGACY Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Jun 29, 2026, at 15:25, sashiko-bot@kernel.org wrote: >> diff --git a/arch/x86/platform/olpc/olpc-xo1-sci.c b/arch/x86/platform/olpc/olpc-xo1-sci.c >> index 30751b42d54ef..a5b47960ba32e 100644 >> --- a/arch/x86/platform/olpc/olpc-xo1-sci.c >> +++ b/arch/x86/platform/olpc/olpc-xo1-sci.c >> @@ -9,7 +9,7 @@ >> >> #include >> #include >> -#include >> +#include > > [Severity: Low] > Does this cause a build failure when setup_ec_sci() and other functions in > this file are compiled? It appears include/linux/gpio/legacy.h does not exist > in the tree, and the legacy GPIO APIs might still be declared directly in > include/linux/gpio.h. The header was added in 7.2-rc1. Arnd