Re: [PATCH 1/2] dt-bindings vnc virtual input

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/07/2025 08:43, marlonwu@126.com wrote:
> From: Menglong Wu <marlonwu@126.com>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Add documentation for virtual GPIO keys to enable full ANSI keyboard
> emulation via VNC on embedded devices without physical keyboards.
> 
> - vnc-virtual-input.txt: Usage scenario and implementation details
> - vnc-virtual-input.yaml: Formal DT binding specification
> - MAINTAINERS: Add entry for VNC virtual input support
> 
> The solution registers virtual GPIOs (starting from 400) to avoid conflicts
> with physical GPIOs while supporting standard Linux input codes.
> 
> Signed-off-by: Menglong Wu <marlonwu@126.com>
> ---
>  .../bindings/input/vnc-virtual-input.txt      | 153 ++++++++++++++++++
>  .../bindings/input/vnc-virtual-input.yaml     |  86 ++++++++++
>  MAINTAINERS                                   |   7 +
>  3 files changed, 246 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/vnc-virtual-input.txt

We do not take txt bindings anymore, sorry.

>  create mode 100644 Documentation/devicetree/bindings/input/vnc-virtual-input.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/vnc-virtual-input.txt b/Documentation/devicetree/bindings/input/vnc-virtual-input.txt
> new file mode 100644
> index 000000000000..77d12308c553
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/vnc-virtual-input.txt
> @@ -0,0 +1,153 @@
> +Register virtual GPIO keys for VNC
> +==========================
> +
> +# Purpose
> +
> +To emulate a full ANSI keyboard on embedded devices without physical
> +keyboards.The server responds to key events via x11vnc.
> +This resolves the limitation where embedded systems only register a few
> +GPIO keys, making them unable to process full keyboard inputs.
> +
> +documented in Documentation/devicetree/bindings/input/vnc-virtual-input.yaml

I don't understand the placement of this file in bindings. What are you
writing bindings for here?


> diff --git a/Documentation/devicetree/bindings/input/vnc-virtual-input.yaml b/Documentation/devicetree/bindings/input/vnc-virtual-input.yaml
> new file mode 100644
> index 000000000000..8b5414cb2bea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/vnc-virtual-input.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VNC Virtual GPIO Keys
> +
> +maintainers:
> +  - Menglong Wu <marlonwu@126.com>
> +
> +description: |
> +  This binding describes a virtual GPIO key input node for VNC remote
> +  input.

Describe the hardware, not the binding...

> +  It is based on the standard gpio-keys binding.
> +
> +select: false
> +
> +allOf:
> +  - $ref: gpio-keys.yaml#
> +
> +properties:
> +  compatible:
> +    const: gpio-keys

So this is all completely redundant and not needed. Drop the bindings.

> +
> +  status:
> +    enum:
> +      - okay
> +      - disabled

Do you see any bindings with this?

Srsly, it's second bindings today. I think you send some AI slops to us.

Please confirm:

Did you use any AI tool to generate this file?

Best regards,
Krzysztof