From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/3] HID: make ishtp_cl_bus_type const
Date: Wed, 20 Dec 2023 04:55:31 -0800 [thread overview]
Message-ID: <90c4f24d697f0dbd5a1afac7d5ac49ffbe6fff14.camel@linux.intel.com> (raw)
In-Reply-To: <2023122048-tribute-quote-1b4d@gregkh>
On Wed, 2023-12-20 at 08:38 +0100, Greg Kroah-Hartman wrote:
> Now that the driver core can properly handle constant struct
> bus_type,
> move the ishtp_cl_bus_type variable to be a constant structure as
> well,
> placing it into read-only memory which can not be modified at
> runtime.
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index 7fc738a22375..aa6cb033bb06 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -378,7 +378,7 @@ static const struct dev_pm_ops
> ishtp_cl_bus_dev_pm_ops = {
> .restore = ishtp_cl_device_resume,
> };
>
> -static struct bus_type ishtp_cl_bus_type = {
> +static const struct bus_type ishtp_cl_bus_type = {
> .name = "ishtp",
> .dev_groups = ishtp_cl_dev_groups,
> .probe = ishtp_cl_device_probe,
next prev parent reply other threads:[~2023-12-20 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 7:38 [PATCH 1/3] HID: make hid_bus_type const Greg Kroah-Hartman
2023-12-20 7:38 ` [PATCH 2/3] HID: make ishtp_cl_bus_type const Greg Kroah-Hartman
2023-12-20 12:55 ` srinivas pandruvada [this message]
2023-12-20 7:38 ` [PATCH 3/3] HID: bpf: make bus_type const in struct hid_bpf_ops Greg Kroah-Hartman
2024-01-02 10:30 ` [PATCH 1/3] HID: make hid_bus_type const Jiri Kosina
2024-01-04 15:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c4f24d697f0dbd5a1afac7d5ac49ffbe6fff14.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).