* [PATCH v3 10/18] input/joystick/analog: Switch from rdtscl() to native_read_tsc()
[not found] <cover.1434501120.git.luto@kernel.org>
@ 2015-06-17 0:35 ` Andy Lutomirski
2015-06-17 0:35 ` [PATCH v3 11/18] drivers/input/gameport: Replace rdtscl() with native_read_tsc() Andy Lutomirski
1 sibling, 0 replies; 2+ messages in thread
From: Andy Lutomirski @ 2015-06-17 0:35 UTC (permalink / raw)
To: x86
Cc: Borislav Petkov, Peter Zijlstra, John Stultz, linux-kernel,
Len Brown, Huang Rui, Denys Vlasenko, kvm, Ralf Baechle,
Andy Lutomirski, linux-input
This timing code is hideous, and this doesn't help. It gets rid of
one of the last users of rdtscl, though.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/input/joystick/analog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analog.c
index 4284080e481d..f871b4f00056 100644
--- a/drivers/input/joystick/analog.c
+++ b/drivers/input/joystick/analog.c
@@ -143,7 +143,7 @@ struct analog_port {
#include <linux/i8253.h>
-#define GET_TIME(x) do { if (cpu_has_tsc) rdtscl(x); else x = get_time_pit(); } while (0)
+#define GET_TIME(x) do { if (cpu_has_tsc) x = (unsigned int)native_read_tsc(); else x = get_time_pit(); } while (0)
#define DELTA(x,y) (cpu_has_tsc ? ((y) - (x)) : ((x) - (y) + ((x) < (y) ? PIT_TICK_RATE / HZ : 0)))
#define TIME_NAME (cpu_has_tsc?"TSC":"PIT")
static unsigned int get_time_pit(void)
@@ -160,7 +160,7 @@ static unsigned int get_time_pit(void)
return count;
}
#elif defined(__x86_64__)
-#define GET_TIME(x) rdtscl(x)
+#define GET_TIME(x) do { x = (unsigned int)native_read_tsc(); } while (0)
#define DELTA(x,y) ((y)-(x))
#define TIME_NAME "TSC"
#elif defined(__alpha__) || defined(CONFIG_MN10300) || defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_TILE)
--
2.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v3 11/18] drivers/input/gameport: Replace rdtscl() with native_read_tsc()
[not found] <cover.1434501120.git.luto@kernel.org>
2015-06-17 0:35 ` [PATCH v3 10/18] input/joystick/analog: Switch from rdtscl() to native_read_tsc() Andy Lutomirski
@ 2015-06-17 0:35 ` Andy Lutomirski
1 sibling, 0 replies; 2+ messages in thread
From: Andy Lutomirski @ 2015-06-17 0:35 UTC (permalink / raw)
To: x86
Cc: Borislav Petkov, Peter Zijlstra, John Stultz, linux-kernel,
Len Brown, Huang Rui, Denys Vlasenko, kvm, Ralf Baechle,
Andy Lutomirski, linux-input
It's unclear to me why this code exists in the first place.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/input/gameport/gameport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c
index e853a2134680..abc0cb22e750 100644
--- a/drivers/input/gameport/gameport.c
+++ b/drivers/input/gameport/gameport.c
@@ -149,9 +149,9 @@ static int old_gameport_measure_speed(struct gameport *gameport)
for(i = 0; i < 50; i++) {
local_irq_save(flags);
- rdtscl(t1);
+ t1 = native_read_tsc();
for (t = 0; t < 50; t++) gameport_read(gameport);
- rdtscl(t2);
+ t2 = native_read_tsc();
local_irq_restore(flags);
udelay(i * 10);
if (t2 - t1 < tx) tx = t2 - t1;
--
2.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread