From: Hans de Goede <hdegoede@redhat.com>
To: Bastien Nocera <hadess@hadess.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: goodix - Try resetting the controller when no config is set
Date: Mon, 31 Oct 2022 19:18:11 +0100 [thread overview]
Message-ID: <9137979f-5d11-5050-0718-39e9fb0cb6f9@redhat.com> (raw)
In-Reply-To: <0ad614f5c69bae7bf7081b32660d41bf4edd906c.camel@hadess.net>
Hi,
On 10/31/22 15:42, Bastien Nocera wrote:
> On Tue, 2022-10-25 at 14:29 +0200, Hans de Goede wrote:
>> On ACPI systems (irq_pin_access_method == IRQ_PIN_ACCESS_ACPI_*) the
>> driver
>> does not reset the controller at probe time, because sometimes the
>> system
>> firmware loads a config and resetting might loose this config.
>
> "lose".
>
> You can add
> Reviewed-by: Bastien Nocera <hadess@hadess.net>
> to all 4 patches in this patchset that don't already have it.
Thank you.
Dmitry, I assume you can fix the small spelling error in the
commit msg while applying this?
Regards,
Hans
next prev parent reply other threads:[~2022-10-31 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 12:29 [PATCH 0/4] Input: touchscreen - Goodix bugfix + settings mod-param support Hans de Goede
2022-10-25 12:29 ` [PATCH 1/4] Input: goodix - Try resetting the controller when no config is set Hans de Goede
2022-10-31 14:42 ` Bastien Nocera
2022-10-31 18:18 ` Hans de Goede [this message]
2022-11-03 18:32 ` Dmitry Torokhov
2022-10-25 12:29 ` [PATCH 2/4] Input: touchscreen - Extend touchscreen_parse_properties() to allow overriding settings with a module option Hans de Goede
2022-11-03 19:28 ` Dmitry Torokhov
2022-11-28 9:43 ` Hans de Goede
2022-10-25 12:29 ` [PATCH 3/4] Input: silead - Add a settings module-parameter Hans de Goede
2022-10-25 12:29 ` [PATCH 4/4] Input: goodix " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9137979f-5d11-5050-0718-39e9fb0cb6f9@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).