From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jikos@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/6] hid-prodikeys: Delete an unnecessary return statement in pcmidi_send_note()
Date: Sat, 3 Feb 2018 18:40:50 +0100 [thread overview]
Message-ID: <92011980-048c-f44b-a064-d2a917b2f51a@users.sourceforge.net> (raw)
In-Reply-To: <c388b4d8-fa43-1bf2-e27d-1a3a8d636118@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 3 Feb 2018 17:33:40 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hid/hid-prodikeys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 7672f723b268..c9eae92ad429 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -235,8 +235,6 @@ static void pcmidi_send_note(struct pcmidi_snd *pm,
drop_note:
spin_unlock_irqrestore(&pm->rawmidi_in_lock, flags);
-
- return;
}
static void pcmidi_sustained_note_release(struct timer_list *t)
--
2.16.1
next prev parent reply other threads:[~2018-02-03 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 17:36 [PATCH 0/6] HID-Prodikeys: Adjustments for two function implementations SF Markus Elfring
2018-02-03 17:37 ` [PATCH 1/6] hid-prodikeys: Delete two error messages for a failed memory allocation in pk_probe() SF Markus Elfring
2018-02-03 17:38 ` [PATCH 2/6] hid-prodikeys: Delete an unnecessary variable initialisation " SF Markus Elfring
2018-02-03 17:39 ` [PATCH 3/6] hid-prodikeys: Move an assignment " SF Markus Elfring
2018-02-03 17:40 ` SF Markus Elfring [this message]
2018-02-03 17:41 ` [PATCH 5/6] hid-prodikeys: Combine two condition checks into one statement in pcmidi_send_note() SF Markus Elfring
2018-02-03 17:42 ` [PATCH 6/6] hid-prodikeys: Rename a jump label " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92011980-048c-f44b-a064-d2a917b2f51a@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).