Linux Input/HID development
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vishal Tyagi <vishalxtyagi.oss@gmail.com>
Cc: Markus Rathgeb <maggu2810@mailbox.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] Revert "Input: synaptics - enable SMBus for HP Elitebook 850 G1"
Date: Fri, 13 Nov 2026 08:00:53 -0800	[thread overview]
Message-ID: <9594e8428a3fbc94e515c9dad2268009@gmail.com> (raw)
In-Reply-To: <179399405216.85438.8327280593401118083@gmail.com>

Hi Vishal,

On Sat, Nov 07, 2026 at 01:10:52AM +0530, Vishal Tyagi wrote:
> Commit f04f03d3e99b ("Input: synaptics - enable SMBus for HP Elitebook 850 G1")
> added PNP ID "SYN3003" to smbus_pnp_ids[] to enable SMBus/InterTouch mode.
>
> However, on Haswell-generation HP EliteBooks sharing this touchpad controller
> (including HP EliteBook 840 G1 and HP EliteBook 850 G1), the touchpad fails
> to resume after ACPI S3 suspend:
>
>   rmi4_smbus 0-002c: failed to get SMBus version number!
>   rmi4_f01 rmi4-00.fn01: Resume failed with code -6.
>   rmi4_physical: Failed to resume rmi4-00: -6

Could you please try the patch recently posted by Markus Rathgeb (CCed)
that retries reading the SMBus version on -ENXIO during resume, and see
if it resolves the S3 resume issue on your EliteBook without reverting
SMBus support:

https://lore.kernel.org/linux-input/20261105204953.69572-1-maggu2810@mailbox.org/

Thanks.

-- 
Dmitry

      reply	other threads:[~2026-11-13 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 19:40 [PATCH] Revert "Input: synaptics - enable SMBus for HP Elitebook 850 G1" Vishal Tyagi
2026-11-13 16:00 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9594e8428a3fbc94e515c9dad2268009@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maggu2810@mailbox.org \
    --cc=stable@vger.kernel.org \
    --cc=vishalxtyagi.oss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox