From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDA6C004D4 for ; Thu, 19 Jan 2023 11:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230396AbjASLan (ORCPT ); Thu, 19 Jan 2023 06:30:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbjASLaZ (ORCPT ); Thu, 19 Jan 2023 06:30:25 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE8A78572 for ; Thu, 19 Jan 2023 03:29:56 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id k16so1268402wms.2 for ; Thu, 19 Jan 2023 03:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c/2ba17zj7VIMK/xPxIvdDUjP5shl1h27sejoZLeZuQ=; b=Qw9NmNb2h3Q/WXN8V5dKD8ZMvIo3a0/mIEIjRNyA53EOfat0tKaG0+L0ynTn+k0bn+ 7nB4MNLiiYgOCG7bjoRS10SdcndOKBq9AwVfBDlD94nOxaxQdV3xD35VPPvWBVtg29O0 3wpX7BiIIIR/hUytdPdEjdj/9zcu+Y492n43AxsG6phf2LHg9p4F6WknT7O61Z48ZEfj zQvdXQWl3GvX79bSXIQ4vV97pmYo9gGScPOml2FX5ndGYGUnSkSDt3lXOGiOzx4NXJoY nSvSiP90PrTm9/BI2ZektMxNMMw0QiFqlkZKkxlMtOWCYyWEouI1VUK3PZUhiek9/Obk Jnag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c/2ba17zj7VIMK/xPxIvdDUjP5shl1h27sejoZLeZuQ=; b=hdyyDyFxGR55Un++05EAfnW4sLMAXXNQr1V1cIqkOIeRe68TlZlXec6oKYf7HpgvSw +jftzs7SeAIS96sSRtIbwhtXMnY+JmoPmRbmIYkI0ZaF7k3mCiOzR/XF0H0MFk+bSZ1Y yGc+HcRIa9ISsaY/02jyh3S0x27iUj1/E45Xzm9CRA3uDcD3dg/+C+by5ImQzwPBJTyG DrwdgLl3LDRFyIB/aptTfx1nA/+uaYfs4NZGvl7PCyJExu9P2n7GOLx1fIgSyWJJfZT3 OzId2lwcppQzdHa84sCrmpYcQqxjYst4CYEmGaM+ktlZfnRTsnugRIAJmXsks7vPhbyR zqCw== X-Gm-Message-State: AFqh2kq7B/E0bhaRyUSIll/NT1jMp2/UTxDW5ZKnK9AH6oBEWv+TQLvP DWGAYvYWNltFWlPW2zDPyNGQoQ== X-Google-Smtp-Source: AMrXdXuMiM4IM//k/gieCDJhxZvpWdnP1PFB01eqMkwELfRhnLAPpWXMgCWEP2v9uPTdedd9+u1RGw== X-Received: by 2002:a05:600c:54d0:b0:3d9:7847:96e2 with SMTP id iw16-20020a05600c54d000b003d9784796e2mr9919025wmb.2.1674127792247; Thu, 19 Jan 2023 03:29:52 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g9-20020a05600c310900b003c21ba7d7d6sm1189775wmo.44.2023.01.19.03.29.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 03:29:51 -0800 (PST) Message-ID: <9622fe3c-0f3a-a3a2-6e35-90befe869d1b@linaro.org> Date: Thu, 19 Jan 2023 12:29:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key Content-Language: en-US To: Gergo Koteles , Dmitry Torokhov , Jonathan Corbet , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Caleb Connolly References: <20230118234638.189098-1-soyer@irl.hu> <20230118234638.189098-4-soyer@irl.hu> From: Krzysztof Kozlowski In-Reply-To: <20230118234638.189098-4-soyer@irl.hu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 19/01/2023 00:46, Gergo Koteles wrote: > The tri-state-key is a sound profile switch found on the OnePlus 6, > Android maps the states to "mute", "vibrate" and "ring", expose them as > ABS_SND_PROFILE events. > The previous GPIO numbers were wrong, the patch updates them to the correct > ones. > > Co-developed-by: Caleb Connolly > Signed-off-by: Caleb Connolly > Signed-off-by: Gergo Koteles > --- > .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 43 ++++++++++++++++++- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > index 42cf4dd5ea28..33215ad17513 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > @@ -49,6 +49,44 @@ key-vol-up { > }; > }; > > + tri-state-key { > + compatible = "gpio-keys"; > + label = "Tri-state key"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&tri_state_key_default>; > + > + state-top { Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + label = "Tri-state key top"; > + linux,input-type = ; > + linux,code = ; > + linux,input-value = <0>; > + gpios = <&tlmm 126 GPIO_ACTIVE_LOW>; > + debounce-interval = <50>; > + linux,can-disable; > + }; > + > + state-middle { > + label = "Tri-state key middle"; > + linux,input-type = ; > + linux,code = ; > + linux,input-value = <1>; > + gpios = <&tlmm 52 GPIO_ACTIVE_LOW>; > + debounce-interval = <50>; > + linux,can-disable; > + }; > + > + state-bottom { > + label = "Tri-state key bottom"; > + linux,input-type = ; > + linux,code = ; > + linux,input-value = <2>; > + gpios = <&tlmm 24 GPIO_ACTIVE_LOW>; > + debounce-interval = <50>; > + linux,can-disable; > + }; > + }; > + > reserved-memory { > /* > * The rmtfs_mem needs to be guarded due to "XPU limitations" > @@ -588,9 +626,10 @@ &usb_1_hsphy { > &tlmm { > gpio-reserved-ranges = <0 4>, <81 4>; > > - tri_state_key_default: tri_state_key_default { > + // The GPIOs have a hardware pullup. > + tri_state_key_default: tri-state-pins { > mux { You need to rebase. Best regards, Krzysztof