Re: [PATCH] input: pm8941-pwrkey: fix dev_dbg() output in pm8941_pwrkey_irq()

[David Collins <quic_collinsd@quicinc.com>]

On 2/16/25 09:03, Dmitry Antipov wrote:
> Since 'sw_debounce_end_time' of 'struct pm8941_pwrkey' is of type
> 'ktime_t', use 'ktime_to_us()' to print the value in microseconds
> as it is announced in a call to 'dev_dbg()'. Compile tested only.
> 
> Fixes: 0b65118e6ba3 ("Input: pm8941-pwrkey - add software key press debouncing support")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

Reviewed-by: David Collins <quic_collinsd@quicinc.com>

Thanks for making this fix.

Take care,
David Collins

> ---
>  drivers/input/misc/pm8941-pwrkey.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/pm8941-pwrkey.c b/drivers/input/misc/pm8941-pwrkey.c
> index d0c46665e527..d952c16f2458 100644
> --- a/drivers/input/misc/pm8941-pwrkey.c
> +++ b/drivers/input/misc/pm8941-pwrkey.c
> @@ -154,8 +154,8 @@ static irqreturn_t pm8941_pwrkey_irq(int irq, void *_data)
>  	if (pwrkey->sw_debounce_time_us) {
>  		if (ktime_before(ktime_get(), pwrkey->sw_debounce_end_time)) {
>  			dev_dbg(pwrkey->dev,
> -				"ignoring key event received before debounce end %llu us\n",
> -				pwrkey->sw_debounce_end_time);
> +				"ignoring key event received before debounce end %lld us\n",
> +				ktime_to_us(pwrkey->sw_debounce_end_time));
>  			return IRQ_HANDLED;
>  		}
>  	}