From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75AF7C4332F for ; Tue, 15 Nov 2022 20:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbiKOU0H (ORCPT ); Tue, 15 Nov 2022 15:26:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbiKOU0F (ORCPT ); Tue, 15 Nov 2022 15:26:05 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63BC12AC64 for ; Tue, 15 Nov 2022 12:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668543905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w+jTwO2YUQPdNXbClE8d8DPM1GRLBF6qiVx04CuY2M0=; b=UjPza62ruXGAJOVAtorm/aoD/BscWuG6ALTRFU4tiRFtT2GlQdK6sMNXCXjKrFoKAF9cVM uA1icyEHKSMS/ssJ3RHLIjy2k66UZAZn6ENaMfKgNdQOqyuXiefcP7hoNOmSMBSeDQCRUc yJeeyzuNyg0gKoO8svtw7P+Cdb2Z94k= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-595-4bLFlQcBPGWFO5d95uepGg-1; Tue, 15 Nov 2022 15:25:03 -0500 X-MC-Unique: 4bLFlQcBPGWFO5d95uepGg-1 Received: by mail-ej1-f71.google.com with SMTP id sh31-20020a1709076e9f00b007ae32b7eb51so8006706ejc.9 for ; Tue, 15 Nov 2022 12:25:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w+jTwO2YUQPdNXbClE8d8DPM1GRLBF6qiVx04CuY2M0=; b=UYu5GU+Xzs7zB0iPo0SUSd3wwkvVNeu43N2Pm1QIsmUQOem9z6A9NHpXy+HWCyEamM WU59T4F9hwPBShOgOPho1yp8ED8dO5WF3xEZvUv9ol0tnDMjiD97LmP8YaVrV/ZXFu4X GiSVxKbwzDCIHJl07HresqjrZd/YGgOydXYCKynsFHQqBRvQQDhO4vUz/TozzihWR9F7 0rPys/lhrhSdPbrpw5Og8ThrU6jwMnNoqGB2X/v9JutT5UNVf3BTxOQ+AVSRfA/x2CId n4LrajIfGa1KhqHtIMB2PcoDZIh5hIIw/TFvOZVdeqjHeWMNwqaiRy6syC39L9K8+s+7 5RqQ== X-Gm-Message-State: ANoB5pkVQ8f2sCis1wthmb7FMGmqv7Qcf+yWQ6kus1KBUce++loXUudw Cx2mFKGPVZ4rn/P0bOSfYXZ4nJhsMUmz+46GHpk9GLcTM3KqxUBDUCMrNSJ5OT9qb+NOcELHxwq EAMZL+q64dPMNN8xHoGgHqDY= X-Received: by 2002:a17:906:3582:b0:7af:206:9327 with SMTP id o2-20020a170906358200b007af02069327mr8219109ejb.154.1668543902444; Tue, 15 Nov 2022 12:25:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf4gp4N3e2dFr2+urUWGuCnhw7jccoeBirXDd/e1OZzKpGM1yYuqTTyfiq2uvTQ//OOTdRSDOw== X-Received: by 2002:a17:906:3582:b0:7af:206:9327 with SMTP id o2-20020a170906358200b007af02069327mr8219089ejb.154.1668543902163; Tue, 15 Nov 2022 12:25:02 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id b19-20020a056402139300b004637489cf08sm6573124edv.88.2022.11.15.12.25.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 12:25:01 -0800 (PST) Message-ID: <98fdf126-7cfd-7c9b-2edc-d49f5143c75c@redhat.com> Date: Tue, 15 Nov 2022 21:25:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 1/7] Revert "platform/x86: ideapad-laptop: check for touchpad support in _CFG" Content-Language: en-US, nl To: =?UTF-8?Q?Eray_Or=c3=a7unus?= , platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, ike.pan@canonical.com, jikos@kernel.org, benjamin.tissoires@redhat.com, dmitry.torokhov@gmail.com, mgross@linux.intel.com, pobrn@protonmail.com References: <20221029120311.11152-1-erayorcunus@gmail.com> <20221029120311.11152-2-erayorcunus@gmail.com> From: Hans de Goede In-Reply-To: <20221029120311.11152-2-erayorcunus@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 10/29/22 14:03, Eray Orçunus wrote: > Last 8 bit of _CFG started being used in later IdeaPads, thus 30th bit > doesn't always show whether device supports touchpad or touchpad switch. > Remove checking bit 30 of _CFG, so older IdeaPads like S10-3 can switch > touchpad again via touchpad attribute. > > This reverts commit b3ed1b7fe3786c8fe795c16ca07cf3bda67b652f. > > Signed-off-by: Eray Orçunus Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/ideapad-laptop.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > index e7a1299e3776..b67bac457a7a 100644 > --- a/drivers/platform/x86/ideapad-laptop.c > +++ b/drivers/platform/x86/ideapad-laptop.c > @@ -46,11 +46,10 @@ static const char *const ideapad_wmi_fnesc_events[] = { > #endif > > enum { > - CFG_CAP_BT_BIT = 16, > - CFG_CAP_3G_BIT = 17, > - CFG_CAP_WIFI_BIT = 18, > - CFG_CAP_CAM_BIT = 19, > - CFG_CAP_TOUCHPAD_BIT = 30, > + CFG_CAP_BT_BIT = 16, > + CFG_CAP_3G_BIT = 17, > + CFG_CAP_WIFI_BIT = 18, > + CFG_CAP_CAM_BIT = 19, > }; > > enum { > @@ -367,8 +366,6 @@ static int debugfs_cfg_show(struct seq_file *s, void *data) > seq_puts(s, " wifi"); > if (test_bit(CFG_CAP_CAM_BIT, &priv->cfg)) > seq_puts(s, " camera"); > - if (test_bit(CFG_CAP_TOUCHPAD_BIT, &priv->cfg)) > - seq_puts(s, " touchpad"); > seq_puts(s, "\n"); > > seq_puts(s, "Graphics: "); > @@ -661,8 +658,7 @@ static umode_t ideapad_is_visible(struct kobject *kobj, > else if (attr == &dev_attr_fn_lock.attr) > supported = priv->features.fn_lock; > else if (attr == &dev_attr_touchpad.attr) > - supported = priv->features.touchpad_ctrl_via_ec && > - test_bit(CFG_CAP_TOUCHPAD_BIT, &priv->cfg); > + supported = priv->features.touchpad_ctrl_via_ec; > else if (attr == &dev_attr_usb_charging.attr) > supported = priv->features.usb_charging; >