From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B56C433FE for ; Tue, 4 Oct 2022 09:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231373AbiJDJlr (ORCPT ); Tue, 4 Oct 2022 05:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbiJDJlZ (ORCPT ); Tue, 4 Oct 2022 05:41:25 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DEDF5A3C7 for ; Tue, 4 Oct 2022 02:38:08 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id w18so11697693wro.7 for ; Tue, 04 Oct 2022 02:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date; bh=w/jnvOzh6Nm6auASOsenLdYqfQP4eJIKrsHZXL+ia8g=; b=S6emkqURkc/CNrKv84/nWjP68IeGyMkcV7Se8543+Fte+ZAcYubSZCZkDrUWaDiOu3 lFXqoZt15o3SbSlo5Ef+9A+zM9xr6nsd+Jfwh3bFJD+8JbxQ/9ReIGHRFoAtmgb7DQ2j qAjnL7vlZJK81G3DSe0oBVo+fOkaRRZV7URlGhEsxXyyxOkUr0+m07kojl8sIWO262ma EXCheUOmyh5TptAsgKWfho1/xjElcQoXOUqE9a7e797XmmqnqyZsz0/57xgVsE4GL7MH dqt+bV6P1FccWWq2UpwITH5n4r6QuTmxjIoVHbcMY1wb3KdVG9gUUbDik1lkTOM3YWyS ECVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=w/jnvOzh6Nm6auASOsenLdYqfQP4eJIKrsHZXL+ia8g=; b=jo7kDUJYclxGAx0wGsBNTOftWtQZYCWRO4OChULYd7HjAW6eY0J/RkzCi/ItZwcdlm GCeM2hGkUedoZOZWeFvNhBhI4MO6rYJ2oqNa5XbJw81nAxZ8h2aXouK0YA4HMwFEqI64 meQJM7HNXXhPLrg1DlMX2BmdE3gwlc486yU7f5o3hL4ytpOqGvjKGBmKDlQyiFPJsPj5 c8V4y0wTvMqnmEB/+VwmUVTaMSYpkjtK+of2qRggx2wB+8k1p9Z74fVoDRNZoICM04mP Tac0Bfn5jX8fPZUtYVXcoLXJ377J6BL0wnnt8RCrpGboF/x9gG0dFODmC3jKJ9iwGmnt +fhg== X-Gm-Message-State: ACrzQf0zP1Ktpm+S1jbMZXPV0bnmgcC7JS21WL0rjS64w989OOpshJP0 5EHjdS55+elZ2GErGe46H4QzZw== X-Google-Smtp-Source: AMsMyM7tCWkt9va9vIziyAHCYuNBZhfPVE9Wbo7e5DX7PX9AQbLIXFEu4qFKjcu5KE+6uQRLXJYyJw== X-Received: by 2002:a05:6000:1786:b0:22e:3955:13a1 with SMTP id e6-20020a056000178600b0022e395513a1mr6356512wrg.624.1664876286047; Tue, 04 Oct 2022 02:38:06 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:58f1:548b:1390:4070? ([2a01:e0a:982:cbb0:58f1:548b:1390:4070]) by smtp.gmail.com with ESMTPSA id a14-20020adfed0e000000b002258235bda3sm11871248wro.61.2022.10.04.02.38.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 02:38:05 -0700 (PDT) Message-ID: <9937c13b-f10c-32a5-49d9-1c9c16fa58e1@linaro.org> Date: Tue, 4 Oct 2022 11:38:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Content-Language: en-US To: Krzysztof Kozlowski , Krzysztof Kozlowski , Bjorn Andersson , Satya Priya , Andy Gross , Alexandre Belloni , Rob Herring , Konrad Dybcio , Lee Jones , Dmitry Torokhov , Alessandro Zummo Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org> <20220928-mdm9615-dt-schema-fixes-v2-5-87fbeb4ae053@linaro.org> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 04/10/2022 10:55, Krzysztof Kozlowski wrote: > On 04/10/2022 10:08, Neil Armstrong wrote: >> The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation, >> and an example section to validate this change. >> >> Signed-off-by: Neil Armstrong >> >> + >> +examples: >> + - | >> + #include >> + ssbi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + pmic@0 { >> + compatible = "qcom,pm8921"; >> + reg = <0>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + >> + interrupt-parent = <&tlmm>; >> + interrupts = <32 IRQ_TYPE_EDGE_RISING>; >> + }; >> + >> + pmic@1 { >> + compatible = "qcom,pm8018", "qcom,pm8921"; >> + reg = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + >> + interrupt-parent = <&tlmm>; >> + interrupts = <33 IRQ_TYPE_EDGE_RISING>; >> + }; > > These two pmics are exactly the same (except compatible), so just keep > one example... unless both are coming from the same, real DTS? It was mainly to exercise the fallback, but it's useless as-is so I'll remove in v3. > > Best regards, > Krzysztof > Thanks, Neil