From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugen Hristev Subject: Re: [PATCH v4 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels Date: Mon, 7 May 2018 13:40:03 +0300 Message-ID: <99e5d795-eaf6-eb07-3f80-d8b09772e5ff@microchip.com> References: <1525084335-11276-1-git-send-email-eugen.hristev@microchip.com> <1525084335-11276-6-git-send-email-eugen.hristev@microchip.com> <20180506182953.6adad5b5@archlinux> <20180506175914.GL10960@piout.net> <20180507102810.GO10960@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180507102810.GO10960@piout.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Jonathan Cameron , ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, nicolas.ferre@microchip.com, dmitry.torokhov@gmail.com, robh@kernel.org List-Id: linux-input@vger.kernel.org On 07.05.2018 13:28, Alexandre Belloni wrote: > On 07/05/2018 09:18:39+0300, Eugen Hristev wrote: >> On 06.05.2018 20:59, Alexandre Belloni wrote: >>> Hi, >>> >>> On 06/05/2018 18:29:53+0100, Jonathan Cameron wrote: >>>> On Mon, 30 Apr 2018 13:32:11 +0300 >>>> Eugen Hristev wrote: >>>> >>>>> This implements the support for position and pressure for the included >>>>> touchscreen support in the SAMA5D2 SOC ADC block. >>>>> Two position channels are added and one for pressure. >>>>> They can be read in raw format, or through a buffer. >>>>> A normal use case is for a consumer driver to register a callback buffer >>>>> for these channels. >>>>> When the touchscreen channels are in the active scan mask, >>>>> the driver will start the touchscreen sampling and push the data to the >>>>> buffer. >>>>> >>>>> Some parts of this patch are based on initial original work by >>>>> Mohamed Jamsheeth Hajanajubudeen and Bandaru Venkateswara Swamy >>>>> >>>>> Signed-off-by: Eugen Hristev >>>> Looks good to me now. >>>> >>>> I'm assuming that once Dmitry and others are happy, I'll take the >>>> series through the IIO tree. Will reply to the cover letter if the >>>> rest of the patches look good to me to let everyone know that without >>>> having to catch this comment down in here! >>>> >>> >>> I'm planning to take both DT patches through the at91 tree once you take >>> the DT bindings patches. >> >> Please take into consideration that those DT patches do not build >> stand-alone, they depend on >> [PATCH v4 7/9] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific >> consumer info >> >> (the DT patches add an include statement of a file which is created in this >> patch). >> > > So the proper way is to actually have the values in the dt instead of > the define and then patch it on the next version of the kernel. > > Or we take the dts patches on the next version. Taking the DTS patches on the next version is fine for me. Thanks >