[PATCH v1 0/2] Input: touchscreen: Minor colibri-vf50-ts cleanups

[PATCH v1 0/2] Input: touchscreen: Minor colibri-vf50-ts cleanups

[Francesco Dolcini]

Hi all,
This series introduce some minor cleanups on colibri-vf50-ts, allow using it
with any IIO ADC input and fix a couple of mistakes in the dt-bindings
documentation.

Francesco

Max Krummenacher (2):
  Input: touchscreen: colibri-vf50-ts: don't depend on VF610_ADC
  dt-bindings: input: colibri-vf50-ts: Improve documentation

 .../input/touchscreen/colibri-vf50-ts.txt        | 16 ++++++++--------
 drivers/input/touchscreen/Kconfig                |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.25.1

[PATCH v1 1/2] Input: touchscreen: colibri-vf50-ts: don't depend on VF610_ADC

[Francesco Dolcini]

From: Max Krummenacher <max.krummenacher@toradex.com>

Any IIO ADC can be used with the driver, so do not depend
on VF610_ADC.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 drivers/input/touchscreen/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 2d70c945b20a..dc90a3ea51ee 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -1335,7 +1335,7 @@ config TOUCHSCREEN_ZFORCE
 
 config TOUCHSCREEN_COLIBRI_VF50
 	tristate "Toradex Colibri on board touchscreen driver"
-	depends on IIO && VF610_ADC
+	depends on IIO
 	depends on GPIOLIB || COMPILE_TEST
 	help
 	  Say Y here if you have a Colibri VF50 and plan to use
-- 
2.25.1

[PATCH v1 2/2] dt-bindings: input: colibri-vf50-ts: Improve documentation

[Francesco Dolcini]

From: Max Krummenacher <max.krummenacher@toradex.com>

Clarify properties definition, drop unused pinctrl-2 state 'gpio'.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 .../input/touchscreen/colibri-vf50-ts.txt        | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/colibri-vf50-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/colibri-vf50-ts.txt
index 2e1490a8fe74..ca304357c374 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/colibri-vf50-ts.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/colibri-vf50-ts.txt
@@ -3,15 +3,16 @@
 Required Properties:
 - compatible must be toradex,vf50-touchscreen
 - io-channels: adc channels being used by the Colibri VF50 module
+    IIO ADC for Y-, X-, Y+, X+ connections
 - xp-gpios: FET gate driver for input of X+
 - xm-gpios: FET gate driver for input of X-
 - yp-gpios: FET gate driver for input of Y+
 - ym-gpios: FET gate driver for input of Y-
-- interrupts: pen irq interrupt for touch detection
-- pinctrl-names: "idle", "default", "gpios"
-- pinctrl-0: pinctrl node for pen/touch detection state pinmux
+- interrupts: pen irq interrupt for touch detection, signal from X plate
+- pinctrl-names: "idle", "default"
+- pinctrl-0: pinctrl node for pen/touch detection, pinctrl must provide
+    pull-up resistor on X+, X-.
 - pinctrl-1: pinctrl node for X/Y and pressure measurement (ADC) state pinmux
-- pinctrl-2: pinctrl node for gpios functioning as FET gate drivers
 - vf50-ts-min-pressure: pressure level at which to stop measuring X/Y values
 
 Example:
@@ -26,9 +27,8 @@ Example:
 		ym-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
 		interrupt-parent = <&gpio0>;
 		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
-		pinctrl-names = "idle","default","gpios";
-		pinctrl-0 = <&pinctrl_touchctrl_idle>;
-		pinctrl-1 = <&pinctrl_touchctrl_default>;
-		pinctrl-2 = <&pinctrl_touchctrl_gpios>;
+		pinctrl-names = "idle","default";
+		pinctrl-0 = <&pinctrl_touchctrl_idle>, <&pinctrl_touchctrl_gpios>;
+		pinctrl-1 = <&pinctrl_touchctrl_default>, <&pinctrl_touchctrl_gpios>;
 		vf50-ts-min-pressure = <200>;
 	};
-- 
2.25.1

Re: [PATCH v1 2/2] dt-bindings: input: colibri-vf50-ts: Improve documentation

[Krzysztof Kozlowski]

On 12/07/2022 12:16, Francesco Dolcini wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Clarify properties definition, drop unused pinctrl-2 state 'gpio'.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH v1 0/2] Input: touchscreen: Minor colibri-vf50-ts cleanups

[Francesco Dolcini]

Hello Dmitry,
just a gently ping.

Let me know if I should change anything or you could just pick this
small series.

Francesco

On Tue, Jul 12, 2022 at 12:16:17PM +0200, Francesco Dolcini wrote:
> Hi all,
> This series introduce some minor cleanups on colibri-vf50-ts, allow using it
> with any IIO ADC input and fix a couple of mistakes in the dt-bindings
> documentation.
> 
> Francesco
> 
> Max Krummenacher (2):
>   Input: touchscreen: colibri-vf50-ts: don't depend on VF610_ADC
>   dt-bindings: input: colibri-vf50-ts: Improve documentation
> 
>  .../input/touchscreen/colibri-vf50-ts.txt        | 16 ++++++++--------
>  drivers/input/touchscreen/Kconfig                |  2 +-
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> -- 
> 2.25.1
> 

Re: [PATCH v1 0/2] Input: touchscreen: Minor colibri-vf50-ts cleanups

[Francesco Dolcini]

Hello all,

On Tue, Jul 12, 2022 at 12:16:17PM +0200, Francesco Dolcini wrote:
> Hi all,
> This series introduce some minor cleanups on colibri-vf50-ts, allow using it
> with any IIO ADC input and fix a couple of mistakes in the dt-bindings
> documentation.
> 
> Max Krummenacher (2):
>   Input: touchscreen: colibri-vf50-ts: don't depend on VF610_ADC
>   dt-bindings: input: colibri-vf50-ts: Improve documentation
> 
>  .../input/touchscreen/colibri-vf50-ts.txt        | 16 ++++++++--------
>  drivers/input/touchscreen/Kconfig                |  2 +-
>  2 files changed, 9 insertions(+), 9 deletions(-)

Just a gently ping on this series, anything I should do?

Francesco

Re: [PATCH v1 1/2] Input: touchscreen: colibri-vf50-ts: don't depend on VF610_ADC

[Dmitry Torokhov]

On Tue, Jul 12, 2022 at 12:16:18PM +0200, Francesco Dolcini wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Any IIO ADC can be used with the driver, so do not depend
> on VF610_ADC.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Applied, thank you.

-- 
Dmitry

Re: [PATCH v1 2/2] dt-bindings: input: colibri-vf50-ts: Improve documentation

[Dmitry Torokhov]

On Tue, Jul 12, 2022 at 12:16:19PM +0200, Francesco Dolcini wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Clarify properties definition, drop unused pinctrl-2 state 'gpio'.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Applied, thank you.

-- 
Dmitry

Re: [PATCH v1 0/2] Input: touchscreen: Minor colibri-vf50-ts cleanups

[Dmitry Torokhov]

On Wed, Aug 31, 2022 at 04:09:11PM +0200, Francesco Dolcini wrote:
> Hello all,
> 
> On Tue, Jul 12, 2022 at 12:16:17PM +0200, Francesco Dolcini wrote:
> > Hi all,
> > This series introduce some minor cleanups on colibri-vf50-ts, allow using it
> > with any IIO ADC input and fix a couple of mistakes in the dt-bindings
> > documentation.
> > 
> > Max Krummenacher (2):
> >   Input: touchscreen: colibri-vf50-ts: don't depend on VF610_ADC
> >   dt-bindings: input: colibri-vf50-ts: Improve documentation
> > 
> >  .../input/touchscreen/colibri-vf50-ts.txt        | 16 ++++++++--------
> >  drivers/input/touchscreen/Kconfig                |  2 +-
> >  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> Just a gently ping on this series, anything I should do?

My apologies, applied the 2 patches, thank you.

-- 
Dmitry