From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jesper Juhl" Subject: Re: [PATCH][hid] Fix a NULL pointer dereference when we fail to allocate memory Date: Mon, 30 Jul 2007 16:04:58 +0200 Message-ID: <9a8748490707300704r238e2a1fn7dcc1f597ed7d5db@mail.gmail.com> References: <200707220006.20359.jesper.juhl@gmail.com> <46A2EF75.70700@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46A2EF75.70700@gmail.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Jiri Slaby Cc: Jiri Kosina , Linux Kernel Mailing List , Michael Haboustak , Andreas Gal , Vojtech Pavlik , Greg Kroah-Hartman , linux-input@atrey.karlin.mff.cuni.cz List-Id: linux-input@vger.kernel.org On 22/07/07, Jiri Slaby wrote: > Jesper Juhl napsal(a): > > drivers/hid/usbhid/hid-core.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c > > index b2baeae..3ff7468 100644 > > --- a/drivers/hid/usbhid/hid-core.c > > +++ b/drivers/hid/usbhid/hid-core.c > > @@ -743,7 +743,7 @@ static struct hid_device *usb_hid_configure(struct usb_interface *intf) > > hid->quirks = quirks; > > > > if (!(usbhid = kzalloc(sizeof(struct usbhid_device), GFP_KERNEL))) > > Out of curiosity, where is this freed? > Sorry, I didn't notice your email until now. It's not freed anywhere :-( But I see that Jiri Kosina just queued a fix for that, so now all is good :-) -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html