linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gregor Riepl <onitake@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Hans de Goede <j.w.r.degoede@gmail.com>
Subject: Re: Support for additional properties in touchscreen.h
Date: Tue, 14 Nov 2017 08:55:01 +0100	[thread overview]
Message-ID: <9b353e37-bba7-c367-bcb1-083e44f4a7b7@gmail.com> (raw)
In-Reply-To: <CAKdAkRS5v8fcL7qzNQxCoos9TxxmTFSArXUcNDjTetVBFcwvAw@mail.gmail.com>

> The fuzz (smoothing the output coordinates) is done in input core and
> the touchscreen properties parsing code already handles
> touchscreen-fuzz-x and touchscreen-fuzz-y parameters. The only thing
> that is needed is to pass these parameters through DT or ACPI or
> static properties, based on particular device.

Thanks for the clarification, Dmitry.

So do I understand correctly that it would suffice to add these parameters to
a DMI match in drivers/platform/x86/silead_dmi.c ?

Something like:

static const struct property_entry my_imaginary_tablet_props[] = {
	PROPERTY_ENTRY_U32("touchscreen-size-x", 1920),
	PROPERTY_ENTRY_U32("touchscreen-size-y", 1080),
	PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 10),
	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 10),
	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-my-imaginary-tablet.fw"),
	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
	{ }
};

  reply	other threads:[~2017-11-14  7:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-11 14:34 Support for additional properties in touchscreen.h Gregor Riepl
2017-11-13 22:13 ` Dmitry Torokhov
2017-11-14  7:55   ` Gregor Riepl [this message]
2017-11-14 18:09     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b353e37-bba7-c367-bcb1-083e44f4a7b7@gmail.com \
    --to=onitake@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=j.w.r.degoede@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).