linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Agarwal, Utsav" <Utsav.Agarwal@analog.com>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Artamonovs, Arturs" <Arturs.Artamonovs@analog.com>,
	"Bimpikas, Vasileios" <Vasileios.Bimpikas@analog.com>,
	"Gaskell, Oliver" <Oliver.Gaskell@analog.com>
Subject: Re: [PATCH v3] adp5588-keys: Support for dedicated gpio operation
Date: Mon, 01 Jul 2024 12:50:15 +0200	[thread overview]
Message-ID: <9bcd2aefd15890f8957e2b2bd767b05a64acb659.camel@gmail.com> (raw)
In-Reply-To: <SJ0PR03MB634333C6AE67823F421B08B59BD32@SJ0PR03MB6343.namprd03.prod.outlook.com>

Hi Utsav,


On Mon, 2024-07-01 at 10:43 +0000, Agarwal, Utsav wrote:
> It seems like there's a typo in the patch from an earlier version of the
> file(dev_err is supplied struct device rather than a struct device pointer). 
> 
> I will be resubmitting it, apologies for the same.
> 

Don't toppost :)...

Also, you're still missing the bindings patch and you're not properly including
a changelog between different versions of your patches.

- Nuno Sá
> 


      reply	other threads:[~2024-07-01 10:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 12:57 [PATCH v2] adp5588-keys: Support for dedicated gpio operation Agarwal, Utsav
2024-06-28 13:15 ` Nuno Sá
2024-06-28 13:38   ` Agarwal, Utsav
2024-06-28 14:04 ` [PATCH v3] " Agarwal, Utsav
2024-07-01 10:43   ` Agarwal, Utsav
2024-07-01 10:50     ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bcd2aefd15890f8957e2b2bd767b05a64acb659.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=Arturs.Artamonovs@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=Oliver.Gaskell@analog.com \
    --cc=Utsav.Agarwal@analog.com \
    --cc=Vasileios.Bimpikas@analog.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).