From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Saenz Julienne Subject: Re: [PATCH v2] HID: core: check whether usage page item is after usage id item Date: Thu, 10 Oct 2019 09:42:45 +0200 Message-ID: <9c7526b57ca330a686439921a0672d50553f4d2d.camel@suse.de> References: <1570625609-11083-1-git-send-email-candlesea@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-5jhaCDq01xP+MKyVBEDl" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Candle Sun Cc: Jiri Kosina , Benjamin Tissoires , orson.zhai@unisoc.com, "open list:HID CORE LAYER" , lkml , Candle Sun , Nianfu Bai List-Id: linux-input@vger.kernel.org --=-5jhaCDq01xP+MKyVBEDl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-10-10 at 11:05 +0800, Candle Sun wrote: > > > -static void hid_concatenate_usage_page(struct hid_parser *parser) > > > +static void hid_concatenate_last_usage_page(struct hid_parser *parse= r) > > > { > > > int i; > > > + unsigned int usage; > > > + unsigned int usage_page =3D parser->global.usage_page; > > > + > > > + if (!parser->local.usage_page_last) > > > + return; > > >=20 > > > for (i =3D 0; i < parser->local.usage_index; i++) > >=20 > > Technically correct but it's preferred if you use braces here. > >=20 >=20 > Nicolas, do you mean this: >=20 > @@ -563,12 +563,13 @@ static void > hid_concatenate_last_usage_page(struct hid_parser *parser) > if (!parser->local.usage_page_last) > return; >=20 > - for (i =3D 0; i < parser->local.usage_index; i++) > + for (i =3D 0; i < parser->local.usage_index; i++) { > if (parser->local.usage_size[i] <=3D 2) { > usage =3D parser->local.usage[i]; > parser->local.usage[i] =3D > GET_COMPLETE_USAGE(usage_page, usage); > } > + } > } Yes, thanks! Regards, Nicolas --=-5jhaCDq01xP+MKyVBEDl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl2e4PUACgkQlfZmHno8 x/69vwgAjR8aeJo21xhyQKJHYyPaFmT+yloEpKJegfetDk817eWMx1SVaaGxTFLv JJ9hiehw004r1WtZcwHiSAI6f2+D4LdjOVUtIhb9Osw9Qj+Zf5nLdBDuKhQJwuAz rVPYNLHr8WUB4x1VW1Y3wa5j1ydD0rohmH2XneiqsuWylFxr/8oQl1UqRTGRsmxC R9WF5HSU49SXE7r7Vm/7JYw+jL07r8ac1EK55PR5p85DxfSmDUYUmw6Rzptq0bT/ JNMzdE5h1bQSi+xQbiCJwCSTN3VAd/5+Rni1ZJeMS8k1jXkU2exNZ6BNN46DG+KY eejOJVdCuVF93W5COr2E/PHkn4mpAg== =8Prm -----END PGP SIGNATURE----- --=-5jhaCDq01xP+MKyVBEDl-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B488C4360C for ; Thu, 10 Oct 2019 07:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F5282196E for ; Thu, 10 Oct 2019 07:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733215AbfJJHmu (ORCPT ); Thu, 10 Oct 2019 03:42:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:53236 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733068AbfJJHmu (ORCPT ); Thu, 10 Oct 2019 03:42:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 234C8AC5B; Thu, 10 Oct 2019 07:42:48 +0000 (UTC) Message-ID: <9c7526b57ca330a686439921a0672d50553f4d2d.camel@suse.de> Subject: Re: [PATCH v2] HID: core: check whether usage page item is after usage id item From: Nicolas Saenz Julienne To: Candle Sun Cc: Jiri Kosina , Benjamin Tissoires , orson.zhai@unisoc.com, "open list:HID CORE LAYER" , lkml , Candle Sun , Nianfu Bai Date: Thu, 10 Oct 2019 09:42:45 +0200 In-Reply-To: References: <1570625609-11083-1-git-send-email-candlesea@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-5jhaCDq01xP+MKyVBEDl" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Message-ID: <20191010074245.Fdpn2ER3TkezM6qm9JAXWODrVfnVAm3A4Mo5lW3l8WQ@z> --=-5jhaCDq01xP+MKyVBEDl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-10-10 at 11:05 +0800, Candle Sun wrote: > > > -static void hid_concatenate_usage_page(struct hid_parser *parser) > > > +static void hid_concatenate_last_usage_page(struct hid_parser *parse= r) > > > { > > > int i; > > > + unsigned int usage; > > > + unsigned int usage_page =3D parser->global.usage_page; > > > + > > > + if (!parser->local.usage_page_last) > > > + return; > > >=20 > > > for (i =3D 0; i < parser->local.usage_index; i++) > >=20 > > Technically correct but it's preferred if you use braces here. > >=20 >=20 > Nicolas, do you mean this: >=20 > @@ -563,12 +563,13 @@ static void > hid_concatenate_last_usage_page(struct hid_parser *parser) > if (!parser->local.usage_page_last) > return; >=20 > - for (i =3D 0; i < parser->local.usage_index; i++) > + for (i =3D 0; i < parser->local.usage_index; i++) { > if (parser->local.usage_size[i] <=3D 2) { > usage =3D parser->local.usage[i]; > parser->local.usage[i] =3D > GET_COMPLETE_USAGE(usage_page, usage); > } > + } > } Yes, thanks! Regards, Nicolas --=-5jhaCDq01xP+MKyVBEDl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl2e4PUACgkQlfZmHno8 x/69vwgAjR8aeJo21xhyQKJHYyPaFmT+yloEpKJegfetDk817eWMx1SVaaGxTFLv JJ9hiehw004r1WtZcwHiSAI6f2+D4LdjOVUtIhb9Osw9Qj+Zf5nLdBDuKhQJwuAz rVPYNLHr8WUB4x1VW1Y3wa5j1ydD0rohmH2XneiqsuWylFxr/8oQl1UqRTGRsmxC R9WF5HSU49SXE7r7Vm/7JYw+jL07r8ac1EK55PR5p85DxfSmDUYUmw6Rzptq0bT/ JNMzdE5h1bQSi+xQbiCJwCSTN3VAd/5+Rni1ZJeMS8k1jXkU2exNZ6BNN46DG+KY eejOJVdCuVF93W5COr2E/PHkn4mpAg== =8Prm -----END PGP SIGNATURE----- --=-5jhaCDq01xP+MKyVBEDl--