linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: "Mark F. Brown" <mark.brown314@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 5/5] ARM: pxa168: aspenite: add board support for keypad
Date: Tue, 31 Aug 2010 13:00:33 +0800	[thread overview]
Message-ID: <AANLkTi=OkRUmBgx_ezWtGHywGJkFAJsdGLR07v8dgzD7@mail.gmail.com> (raw)
In-Reply-To: <1282814339-10934-6-git-send-email-mark.brown314@gmail.com>

On Thu, Aug 26, 2010 at 5:18 PM, Mark F. Brown <mark.brown314@gmail.com> wrote:
> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> ---
>  arch/arm/mach-mmp/aspenite.c |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/aspenite.c b/arch/arm/mach-mmp/aspenite.c
> index 9e1bd6b..1b788c5 100644
> --- a/arch/arm/mach-mmp/aspenite.c
> +++ b/arch/arm/mach-mmp/aspenite.c
> @@ -24,6 +24,8 @@
>  #include <mach/pxa168.h>
>  #include <mach/gpio.h>
>  #include <video/pxa168fb.h>
> +#include <linux/input.h>
> +#include <plat/pxa27x_keypad.h>
>
>  #include "common.h"
>
> @@ -97,6 +99,13 @@ static unsigned long common_pin_config[] __initdata = {
>        GPIO81_LCD_DD21,
>        GPIO82_LCD_DD22,
>        GPIO83_LCD_DD23,
> +
> +       /* Keypad */
> +       GPIO109_KP_MKIN1,
> +       GPIO110_KP_MKIN0,
> +       GPIO111_KP_MKOUT7,
> +       GPIO112_KP_MKOUT6,
> +       GPIO121_KP_MKIN4,
>  };
>
>  static struct smc91x_platdata smc91x_info = {
> @@ -193,6 +202,23 @@ struct pxa168fb_mach_info aspenite_lcd_info = {
>        .invert_pixclock        = 0,
>  };
>
> +static unsigned int aspenite_matrix_key_map[] = {
> +       KEY(0, 6, KEY_UP),      /* SW 4 */
> +       KEY(0, 7, KEY_DOWN),    /* SW 5 */
> +       KEY(1, 6, KEY_LEFT),    /* SW 6 */
> +       KEY(1, 7, KEY_RIGHT),   /* SW 7 */
> +       KEY(4, 6, KEY_ENTER),   /* SW 8 */
> +       KEY(4, 7, KEY_ESC),     /* SW 9 */
> +};
> +
> +static struct pxa27x_keypad_platform_data aspenite_keypad_info __initdata = {
> +       .matrix_key_rows        = 8,
> +       .matrix_key_cols        = 8,
It seems that maxium columns is 5, not 8.

> +       .matrix_key_map         = aspenite_matrix_key_map,
> +       .matrix_key_map_size    = ARRAY_SIZE(aspenite_matrix_key_map),
> +       .debounce_interval      = 30,
> +};
> +
>  static void __init common_init(void)
>  {
>        mfp_config(ARRAY_AND_SIZE(common_pin_config));
> @@ -203,6 +229,7 @@ static void __init common_init(void)
>        pxa168_add_ssp(1);
>        pxa168_add_nand(&aspenite_nand_info);
>        pxa168_add_fb(&aspenite_lcd_info);
> +       pxa168_add_keypad(&aspenite_keypad_info);
>
>        /* off-chip devices */
>        platform_device_register(&smc91x_device);
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-08-31  5:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1282814339-10934-1-git-send-email-mark.brown314@gmail.com>
2010-08-26  9:18 ` [PATCH 1/5] ARM: pxa27x/pxa3xx: moved pxa27x_keypad.h to platform pxa directory Mark F. Brown
2010-08-31  4:13   ` Eric Miao
2010-08-26  9:18 ` [PATCH 2/5] ARM: pxa168: added keypad support Mark F. Brown
2010-08-31  4:56   ` Haojian Zhuang
2010-08-26  9:18 ` [PATCH 3/5] ARM: pxa168: added wake clear register support for APMU Mark F. Brown
2010-08-26  9:18 ` [PATCH 4/5] ARM: pxa168: added special case handler for keypad interrupts Mark F. Brown
2010-08-26  9:18 ` [PATCH 5/5] ARM: pxa168: aspenite: add board support for keypad Mark F. Brown
     [not found] ` <1282814339-10934-5-git-send-email-mark.brown314@gmail.com>
2010-08-31  4:53   ` [PATCH 4/5] ARM: pxa168: added special case handler for keypad interrupts Haojian Zhuang
2010-08-31  6:28     ` Mark F. Brown
2010-08-31  7:05       ` Eric Miao
2010-08-31  7:13         ` Mark F. Brown
2010-08-31  7:15           ` Eric Miao
     [not found] ` <1282814339-10934-6-git-send-email-mark.brown314@gmail.com>
2010-08-31  5:00   ` Haojian Zhuang [this message]
2010-09-03  4:50     ` [PATCH 5/5] ARM: pxa168: aspenite: add board support for keypad Mark F. Brown
2010-09-03 14:11       ` Marek Vasut
2010-09-03 14:39         ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=OkRUmBgx_ezWtGHywGJkFAJsdGLR07v8dgzD7@mail.gmail.com' \
    --to=haojian.zhuang@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.brown314@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).