Re: [PATCH RFC 1/3] sound: ac97: Add GPIO manipulation hooks

[Manuel Lauss <manuel.lauss@googlemail.com>]

On Wed, Jun 16, 2010 at 9:55 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> >  include/sound/ac97_codec.h |    2 ++
>> >  1 files changed, 2 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/sound/ac97_codec.h b/include/sound/ac97_codec.h
>> > index 4940045..db3aee1 100644
>> > --- a/include/sound/ac97_codec.h
>> > +++ b/include/sound/ac97_codec.h
>> > @@ -437,6 +437,8 @@ struct snd_ac97_bus_ops {
>> >     unsigned short (*read) (struct snd_ac97 *ac97, unsigned short reg);
>> >     void (*wait) (struct snd_ac97 *ac97);
>> >     void (*init) (struct snd_ac97 *ac97);
>> > +   void (*setgpio) (struct snd_ac97 *ac97, unsigned short gpio);
>> > +   unsigned short (*getgpio) (struct snd_ac97 *ac97);
>
> Can this be handled simply in read/write callbacks in the controller
> side?  In callbacks, you can check whether reg == AC97_GPIO_STATUS and
> handle differently for such an access.

Interesting Idea, and as a bonus requires no changes to the wm97xx code.

Thank you!
      Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html