Re: [PATCH v2] input: qt602240 - Add ATMEL QT602240 touchscreen driver

[Dan Murphy <murpdj72@gmail.com>]

On Mon, Jun 28, 2010 at 9:26 AM, Dan Murphy <murpdj72@gmail.com> wrote:
>
> I don't see any error handling from the IC here.
>
> Generally this IC should give a few error messages if a X/Y line is broken, the chip goes into reset, or the chip is missed configured.
>
> This is a bad situation here
> +       /* Read dummy message to make high CHG pin */
> +       do {
> +               ret = qt602240_read_object(data, QT602240_GEN_MESSAGE, 0);
> +               if (ret < 0)
> +                       return ret;
> +       } while (ret != 0xff);
>
> The chip may have an error and constantly send you the message which means you will never get out of this loop.  This can be bad as your probe or load_fw may never return.
>
>
>
> Dan
>
> On Mon, Jun 28, 2010 at 8:41 AM, Joonyoung Shim <dofmind@gmail.com> wrote:
>>
>> 2010/6/28 Henrik Rydberg <rydberg@euromail.se>:
>> > Joonyoung Shim wrote:
>> > [...]
>> >> What is the full set of anonymous contacts? It needs the description of
>> >> case sending event for a finger going away.
>> >
>> > I disagree. Protocol A deals with devices that do not necessarily know what
>> > going away means. There is a whole new protocol devoted to your kind of
>> > hardware, type B, and using protocol A is simply not encouraged.
>> >
>>
>> If so, i'm fine.
>>
>> Thanks.
>>
>>
>> --
>> - Joonyoung Shim
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html