From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Richard Nauber <richard.nauber@googlemail.com>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Henrik Rydberg <rydberg@euromail.se>
Subject: Re: [RFC] Port of hid-egalax to the unified hid-multitouch driver
Date: Mon, 7 Mar 2011 11:04:14 +0100 [thread overview]
Message-ID: <AANLkTikWm3iBwqSTsQZWsLZ4b_q2aScUEo4dW9GJ9Kcz@mail.gmail.com> (raw)
In-Reply-To: <1299417883.9645.494.camel@itzy>
Hi Richard,
Thank you very much for this work. This reminds me that we have to
switch the other drivers to hid-multitouch too.
Actually, I was not in favor of porting this driver into
hid-multitouch. eGalax has two differents protocols: one for resistive
technology (which is compatible with hid-multitouch in its current
form), and one for capacitive technology (which requires the "corrupt
packet length" quirk).
Apparently, according to the kernel logs the Samsung MB30 is a
resistive technology (correct me if I'm wrong). This means that we
also need testings for the capacitive one.
I'll let the community decide whether we should include this in
hid-multitouch. Henrik, Jiri, any idea?
Now let's go for the review!
Cheers,
Benjamin
On Sun, Mar 6, 2011 at 14:24, Richard Nauber
<richard.nauber@googlemail.com> wrote:
> Hi everyone,
> I wrote this little patch that merges hid-egalax into hid-multitouch.
> (It applies to 2.6.38-rc7, but I can rebase it as you please...) The
> latter driver has to gain a new quirk type (MT_QUIRK_EGALAX) for fixing
> the reported ranges (X,Y and Z) and work around the corrupt packet
> length (td->last_field_index).
> With these changes it works like a charm for my Samsung MB30
> touchscreen and by the way fixes the broken suspend/resume behavior.
>
> So I'd like you to test it for other egalax devices and give me your
> feedback on this patch.
>
> Thanks and Greetings,
> Richard
>
> [input-hid] Add hid-egalax driver to the unified hid-multitouch
> framework.
>
> drivers/hid/Kconfig | 9 +-
> drivers/hid/Makefile | 1 -
> drivers/hid/hid-egalax.c | 279
> ------------------------------------------
> drivers/hid/hid-multitouch.c | 48 +++++++-
> 4 files changed, 47 insertions(+), 290 deletions(-)
> delete mode 100644 drivers/hid/hid-egalax.c
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-07 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 13:24 [RFC] Port of hid-egalax to the unified hid-multitouch driver Richard Nauber
2011-03-07 10:04 ` Benjamin Tissoires [this message]
2011-03-08 13:14 ` Jiri Kosina
2011-03-08 13:29 ` Henrik Rydberg
2011-03-08 15:12 ` Benjamin Tissoires
2011-03-08 15:21 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikWm3iBwqSTsQZWsLZ4b_q2aScUEo4dW9GJ9Kcz@mail.gmail.com \
--to=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=richard.nauber@googlemail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).