Re: [PATCH RFC 1/3] sound: ac97: Add GPIO manipulation hooks

[Manuel Lauss <manuel.lauss@googlemail.com>]

On Tue, Jun 15, 2010 at 6:02 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jun 15, 2010 at 05:55:45PM +0200, Manuel Lauss wrote:
>> Add callbacks to struct snd_ac97 to set and retrieve ac97 codec
>> GPIO status.
>
>> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
>
> CCing in Takashi since this is generic AC'97 stuff.
>
>> ---
>>  include/sound/ac97_codec.h |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/sound/ac97_codec.h b/include/sound/ac97_codec.h
>> index 4940045..db3aee1 100644
>> --- a/include/sound/ac97_codec.h
>> +++ b/include/sound/ac97_codec.h
>> @@ -437,6 +437,8 @@ struct snd_ac97_bus_ops {
>>       unsigned short (*read) (struct snd_ac97 *ac97, unsigned short reg);
>>       void (*wait) (struct snd_ac97 *ac97);
>>       void (*init) (struct snd_ac97 *ac97);
>> +     void (*setgpio) (struct snd_ac97 *ac97, unsigned short gpio);
>> +     unsigned short (*getgpio) (struct snd_ac97 *ac97);
>>  };
>>
>>  struct snd_ac97_bus {
>> --
>> 1.7.1
>>
>
> So, I'd kind of expect some sort of interaction with gpiolib somewhere
> if we do support GPIOs (I know the WM97xx custom stuff doesn't currently
> use GPIOs but...).

If I ever get access to the testhardware again, I'll implement it in
the wm97xx core.

        Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html