From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Subject: Re: [PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support Date: Sun, 30 May 2010 13:46:03 +0900 Message-ID: References: <1275188784-23395-1-git-send-email-jy0922.shim@samsung.com> <201005300542.37715.marek.vasut@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:49049 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912Ab0E3EqE convert rfc822-to-8bit (ORCPT ); Sun, 30 May 2010 00:46:04 -0400 In-Reply-To: <201005300542.37715.marek.vasut@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Marek Vasut Cc: Joonyoung Shim , ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org, kyungmin.park@samsung.com, dmitry.torokhov@gmail.com On Sun, May 30, 2010 at 12:42 PM, Marek Vasut w= rote: > Dne Ne 30. kv=C4=9Btna 2010 05:06:20 Joonyoung Shim napsal(a): >> +struct samsung_kp_platdata { >> + =C2=A0 =C2=A0 const struct matrix_keymap_data *keymap_data; >> + =C2=A0 =C2=A0 unsigned int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= rows; >> + =C2=A0 =C2=A0 unsigned int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= cols; >> + =C2=A0 =C2=A0 unsigned int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= rep; > > I don't know, maybe using uint32_t here? On ARM, it doesn't matter so= far as int > will be always 32bit, but maybe we should just type the variables wel= l ? I thought int was 32bits on all archs -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html