* drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared
@ 2011-02-08 20:03 Geert Uytterhoeven
2011-02-08 21:10 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2011-02-08 20:03 UTC (permalink / raw)
To: Sourav Poddar, Wolfram Sang, Dmitry Torokhov
Cc: Linux-Next, linux-input, linux-kernel
linux-next/m68k-allmodconfig/m68k:
http://kisskb.ellerman.id.au/kisskb/buildresult/3899710/
drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN'
undeclared (first use in this function)
drivers/input/touchscreen/ads7846.c:959: error: (Each undeclared
identifier is reported only once
drivers/input/touchscreen/ads7846.c:959: error: for each function it
appears in.)
make[4]: *** [drivers/input/touchscreen/ads7846.o] Error 1
As of commit e9b6e245c727767e6d64cb3dd47a0c6982aa5d23
("Input: ads7846 - use gpio_request_one to configure pendown_gpio"), this
driver should depend on GENERIC_GPIO?
Else <linux/gpio.h> doesn't include <asm/gpio.h>, and we never see the
definition of GPIOF_DIR_IN.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared
2011-02-08 20:03 drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared Geert Uytterhoeven
@ 2011-02-08 21:10 ` Dmitry Torokhov
2011-02-08 21:20 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2011-02-08 21:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sourav Poddar, Wolfram Sang, Linux-Next, linux-input,
linux-kernel
On Tue, Feb 08, 2011 at 09:03:27PM +0100, Geert Uytterhoeven wrote:
> linux-next/m68k-allmodconfig/m68k:
> http://kisskb.ellerman.id.au/kisskb/buildresult/3899710/
>
> drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN'
> undeclared (first use in this function)
> drivers/input/touchscreen/ads7846.c:959: error: (Each undeclared
> identifier is reported only once
> drivers/input/touchscreen/ads7846.c:959: error: for each function it
> appears in.)
> make[4]: *** [drivers/input/touchscreen/ads7846.o] Error 1
>
> As of commit e9b6e245c727767e6d64cb3dd47a0c6982aa5d23
> ("Input: ads7846 - use gpio_request_one to configure pendown_gpio"), this
> driver should depend on GENERIC_GPIO?
> Else <linux/gpio.h> doesn't include <asm/gpio.h>, and we never see the
> definition of GPIOF_DIR_IN.
Crap, sorry about that, I'll fix it up tonight.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared
2011-02-08 21:10 ` Dmitry Torokhov
@ 2011-02-08 21:20 ` Wolfram Sang
2011-02-09 7:34 ` Igor Grinberg
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2011-02-08 21:20 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Geert Uytterhoeven, Sourav Poddar, Linux-Next, linux-input,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Tue, Feb 08, 2011 at 01:10:36PM -0800, Dmitry Torokhov wrote:
> Crap, sorry about that, I'll fix it up tonight.
I had the same issue while working on some other gpio-cleanup.
I am just about to finish a patch.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared
2011-02-08 21:20 ` Wolfram Sang
@ 2011-02-09 7:34 ` Igor Grinberg
0 siblings, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-02-09 7:34 UTC (permalink / raw)
To: Wolfram Sang
Cc: Dmitry Torokhov, Geert Uytterhoeven, Sourav Poddar, Linux-Next,
linux-input, linux-kernel
On 02/08/11 23:20, Wolfram Sang wrote:
> On Tue, Feb 08, 2011 at 01:10:36PM -0800, Dmitry Torokhov wrote:
>
>> Crap, sorry about that, I'll fix it up tonight.
> I had the same issue while working on some other gpio-cleanup.
> I am just about to finish a patch.
This was pretty obvious and I had a thought that this will happen,
but failed in sharing my thoughts with you back then.
May be because of too much talking around it... Sorry... :(
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-09 7:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-08 20:03 drivers/input/touchscreen/ads7846.c:959: error: 'GPIOF_DIR_IN' undeclared Geert Uytterhoeven
2011-02-08 21:10 ` Dmitry Torokhov
2011-02-08 21:20 ` Wolfram Sang
2011-02-09 7:34 ` Igor Grinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).