From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarod Wilson Subject: Re: [PATCH 1/2] ir-core: centralize sysfs raw decoder enabling/disabling Date: Wed, 16 Jun 2010 16:39:05 -0400 Message-ID: References: <20100613202718.6044.29599.stgit@localhost.localdomain> <20100613202930.6044.97940.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:33978 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595Ab0FPUjJ convert rfc822-to-8bit (ORCPT ); Wed, 16 Jun 2010 16:39:09 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: =?ISO-8859-1?Q?David_H=E4rdeman?= Cc: jarod@redhat.com, linux-media@vger.kernel.org, mchehab@redhat.com, linux-input@vger.kernel.org On Wed, Jun 16, 2010 at 4:05 PM, Jarod Wilson wrot= e: > On Sun, Jun 13, 2010 at 4:29 PM, David H=E4rdeman = wrote: >> With the current logic, each raw decoder needs to add a copy of the = exact >> same sysfs code. This is both unnecessary and also means that (re)lo= ading >> an IR driver after raw decoder modules have been loaded won't work a= s >> expected. >> >> This patch moves that logic into ir-raw-event and adds a single sysf= s >> file per device. >> >> Reading that file returns something like: >> >> =A0 =A0 =A0 =A0"rc5 [rc6] nec jvc [sony]" >> >> (with enabled protocols in [] brackets) >> >> Writing either "+protocol" or "-protocol" to that file will >> enable or disable the according protocol decoder. >> >> An additional benefit is that the disabling of a decoder will be >> remembered across module removal/insertion so a previously >> disabled decoder won't suddenly be activated again. The default >> setting is to enable all decoders. >> >> This is also necessary for the next patch which moves even more deco= der >> state into the central raw decoding structs. >> >> Signed-off-by: David H=E4rdeman > > Acked-by: Jarod Wilson > Tested-by: Jarod Wilson > > Note that I was running a version rebased atop the linuxtv staging/rc > branch though. =46ound here: http://git.wilsonet.com//linux-2.6-ir-wip.git?a=3Dcommitdiff;h=3De4166a= 6c70c4f9a06644ce8b4e9beeea7c336d90 --=20 Jarod Wilson jarod@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html