From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Smirl Subject: Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it. Date: Fri, 30 Jul 2010 07:51:31 -0400 Message-ID: References: <1280456235-2024-1-git-send-email-maximlevitsky@gmail.com> <1280456235-2024-14-git-send-email-maximlevitsky@gmail.com> <1280461565.15737.124.camel@localhost> <1280489761.3646.3.camel@maxim-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:62971 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544Ab0G3Lvc convert rfc822-to-8bit (ORCPT ); Fri, 30 Jul 2010 07:51:32 -0400 In-Reply-To: <1280489761.3646.3.camel@maxim-laptop> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Maxim Levitsky Cc: Andy Walls , lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Christoph Bartelmus On Fri, Jul 30, 2010 at 7:36 AM, Maxim Levitsky wrote: > On Thu, 2010-07-29 at 23:46 -0400, Andy Walls wrote: >> On Thu, 2010-07-29 at 22:39 -0400, Jon Smirl wrote: >> > On Thu, Jul 29, 2010 at 10:17 PM, Maxim Levitsky >> > wrote: >> > > note that error_adjustment module option is added. >> > > This allows to reduce input samples by a percent. >> > > This makes input on my system more correct. >> > > >> > > Default is 4% as it works best here. >> > > >> > > Note that only normal input is adjusted. I don't know >> > > what adjustments to apply to fan tachometer input. >> > > Maybe it is accurate already. >> > >> > Do you have the manual for the ENE chip in English? or do you read= Chinese? >> >> The datasheet for a similar chip, the KB3700, is out there in Englis= h, >> but it doesn't have CIR. >> >> You might find these links mildly interesting: >> >> http://www.coreboot.org/Embedded_controller >> http://wiki.laptop.org/go/Embedded_controller >> http://lists.laptop.org/pipermail/openec/2008-July/000108.html > > Nope, I have read that. >> >> Regards, >> Andy >> >> > Maybe you can figure out why the readings are off by 4%. I suspect >> > that someone has set a clock divider wrong when programming the ch= ip. >> > For example setting the divider for a 25Mhz clock when the clock i= s >> > actually 26Mhz would cause the error you are seeing. Or they just = made >> > a mistake in computing the divisor. It is probably a bug in the BI= OS >> > of your laptop. =A0If that's the case you could add a quirk in the >> > system boot code to fix the register setting. > > I figured out how windows driver compensates for the offset, and do t= he > same in my driver. I think the problem is solved. > Should that be a <=3D or >=3D instead of !=3D? + if (pll_freq !=3D 1000) Programming the PLL wrong would cause the 4% error. hw_revision =3D ene_hw_read_reg(dev, ENE_HW_VERSION); old_ver =3D ene_hw_read_reg(dev, ENE_HW_VER_OLD); + pll_freq =3D (ene_hw_read_reg(dev, ENE_PLLFRH) << 4) + + (ene_hw_read_reg(dev, ENE_PLLFRL) >> 2); + + if (pll_freq !=3D 1000) + dev->rx_period_adjust =3D 4; + else + dev->rx_period_adjust =3D 2; + + + ene_printk(KERN_NOTICE, "PLL freq =3D %d\n", pll_freq); + if (hw_revision =3D=3D 0xFF) { > > Best regards, > Maxim Levitsky > > --=20 Jon Smirl jonsmirl@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html