From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Richard Nauber <richard.nauber@googlemail.com>
Cc: "Henrik Rydberg" <rydberg@euromail.se>,
linux-input <linux-input@vger.kernel.org>,
"Jiri Kosina" <jkosina@suse.cz>,
"Stéphane Chatty" <chatty@enac.fr>
Subject: Re: [PATCH v3] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework.
Date: Fri, 11 Mar 2011 07:53:03 +0100 [thread overview]
Message-ID: <AANLkTims5Qg3m7pe-PBFNjmTmeOCPi6i8wqqrK1OJS84@mail.gmail.com> (raw)
In-Reply-To: <1299823326.1910.11.camel@itzy>
Hi Richard,
I'm really sorry, but it's a NACK for me:
what ever Henrik said, I do not want to have numerical constants
throughout the code. It would be the open door to many others. The
reason we have "mt_class" is to regroup each per-device parameters in
it. So there is no need to introduce those constants everywhere.
Cheers,
Benjamin
On Fri, Mar 11, 2011 at 07:02, Richard Nauber
<richard.nauber@googlemail.com> wrote:
> Hi,
>
> Except for a missing comma, Henriks patch works fine for me and I would
> be glad to have it submitted. So feel free to add my SIGNED-OFF-BY.
> (Or should I repost the patch?)
>
> Greetings and thanks to all,
> Richard
>
> --- snip ---
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 57575ff..ee01e65 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -131,7 +131,7 @@ struct mt_class mt_classes[] = {
> { .name = MT_CLS_EGALAX,
> .quirks = MT_QUIRK_SLOT_IS_CONTACTID |
> MT_QUIRK_VALID_IS_INRANGE |
> - MT_QUIRK_EGALAX_XYZ_FIXUP
> + MT_QUIRK_EGALAX_XYZ_FIXUP,
> .maxcontacts = 2,
> .sn_move = 4096,
> .sn_pressure = 32,
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-11 6:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 13:25 [PATCH] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework Richard Nauber
2011-03-07 10:07 ` Benjamin Tissoires
2011-03-08 6:08 ` [PATCH v2] " Richard Nauber
2011-03-08 8:04 ` Henrik Rydberg
2011-03-08 8:55 ` Benjamin Tissoires
2011-03-08 9:14 ` Henrik Rydberg
2011-03-08 9:23 ` Benjamin Tissoires
2011-03-08 9:46 ` Henrik Rydberg
2011-03-08 23:38 ` [PATCH v3] " Richard Nauber
2011-03-09 8:24 ` Henrik Rydberg
2011-03-09 8:54 ` Benjamin Tissoires
2011-03-09 9:23 ` Henrik Rydberg
2011-03-09 10:06 ` Benjamin Tissoires
2011-03-09 11:40 ` Henrik Rydberg
2011-03-11 6:02 ` Richard Nauber
2011-03-11 6:53 ` Benjamin Tissoires [this message]
2011-03-11 9:23 ` Richard Nauber
2011-03-11 9:52 ` Benjamin Tissoires
2011-03-11 11:31 ` Henrik Rydberg
2011-03-14 12:06 ` Jiri Kosina
2011-03-08 13:12 ` [PATCH] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTims5Qg3m7pe-PBFNjmTmeOCPi6i8wqqrK1OJS84@mail.gmail.com \
--to=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=richard.nauber@googlemail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).