[PATCH 1/2] HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[PATCH 1/2] HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[Antonio Orefice]

This patch add supports for force feedback Thrustmaster "F430 Force
Feedback" steering wheel.
I just added the right usb device id to the existing hid-tmff driver
by Zinx Verituse and to the exceptions list in hid-core.c
After the patches, the device correctly supports constant forces.
For example, the wheel will move correctly accordingly to the mouse
position when using ffmvforce from ffutils; ffset is able to set
autocenter strenght and ff gain.

I tested the patches over a 2.6.35 kernel, but the changes are so
minimal that they should work flawlessy on newer ones.

--- hid-tmff.c-2.6.35	2010-11-16 13:54:29.563224822 +0100
+++ hid-tmff.c	2010-11-16 13:46:42.549871515 +0100
@@ -251,8 +252,12 @@
 		.driver_data = (unsigned long)ff_rumble },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651),	/* FGT Rumble
Force Wheel */
 		.driver_data = (unsigned long)ff_rumble },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654),	/* FGT Force
Feedback Wheel */
 		.driver_data = (unsigned long)ff_joystick },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a),	/* F430 Force
Feedback */
+		.driver_data = (unsigned long)ff_joystick },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, tm_devices);

Re: [PATCH 1/2] HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

On Wed, 17 Nov 2010 09:41:17 +0100
Antonio Orefice <aorefice77@gmail.com> wrote:

Hi Antonio, have I heard of you from unina?

> 
> --- hid-tmff.c-2.6.35	2010-11-16 13:54:29.563224822 +0100
> +++ hid-tmff.c	2010-11-16 13:46:42.549871515 +0100
> @@ -251,8 +252,12 @@
>  		.driver_data = (unsigned long)ff_rumble },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651),	/* FGT Rumble
> Force Wheel */
>  		.driver_data = (unsigned long)ff_rumble },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654),	/* FGT Force
> Feedback Wheel */
>  		.driver_data = (unsigned long)ff_joystick },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a),	/* F430 Force
> Feedback */
> +		.driver_data = (unsigned long)ff_joystick },
>  	{ }
>  };

Patch looks space damaged, check your email client settings. Why don't
you try using git (or at least quilt) instead of manual diffing? Tools
are there for a reason :)

Also, I really think the two patches can be folded into one, the commit
messages are telling us so.

Regards,
   Antonio Ospite

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 1/2] HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[simon]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

> Patch looks space damaged, check your email client settings. Why don't
> you try using git (or at least quilt) instead of manual diffing? Tools
> are there for a reason :)
>

On behalf of Antonio, please find attached a git-ized version of the patch.

This builds OK, but I don't have the wheel to test.

Cheers,
Simon Wood.
http://www.speed-dreams.org

[-- Attachment #2: 0001-This-patch-add-supports-for-force-feedback-Thrustmas.patch --]
[-- Type: application/octet-stream, Size: 1729 bytes --]

From 7492b6b93ccb990448b9eda3a1d8277819c81abd Mon Sep 17 00:00:00 2001
From: Simon Wood <simon@mungewell.org>
Date: Wed, 17 Nov 2010 18:37:05 -0700
Subject: [PATCH] This patch add supports for force feedback Thrustmaster "F430 Force
 Feedback" steering wheel.

Reported by: "Antonio Orefice" <aorefice77@gmail.com>
---
 drivers/hid/hid-core.c |    1 +
 drivers/hid/hid-tmff.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 515345b..88cb04e 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1386,6 +1386,7 @@ static const struct hid_device_id hid_blacklist[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb653) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED2, USB_DEVICE_ID_TOPSEED2_RF_COMBO) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_TWINHAN, USB_DEVICE_ID_TWINHAN_IR_REMOTE) },
diff --git a/drivers/hid/hid-tmff.c b/drivers/hid/hid-tmff.c
index 15434c8..25be4e1 100644
--- a/drivers/hid/hid-tmff.c
+++ b/drivers/hid/hid-tmff.c
@@ -256,6 +256,8 @@ static const struct hid_device_id tm_devices[] = {
 		.driver_data = (unsigned long)ff_joystick },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654),	/* FGT Force Feedback Wheel */
 		.driver_data = (unsigned long)ff_joystick },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a),	/* F430 Force Feedback Wheel */
+		.driver_data = (unsigned long)ff_joystick },
 	{ }
 };
 MODULE_DEVICE_TABLE(hid, tm_devices);
-- 
1.7.0.4