From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Subject: Re: [PATCH] Input: tca6416-keypad: Change to module_init() Date: Thu, 24 Mar 2011 12:38:21 +0900 Message-ID: References: <20110322143307.GB24004@linux-sh.org> <20110322153226.GC30303@linux-sh.org> <20110322155730.GD30303@linux-sh.org> <20110322163144.GC2202@sirena.org.uk> <20110322165907.GG22583@opensource.wolfsonmicro.com> <20110323162021.GA26594@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20110323162021.GA26594-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Paul Mundt , dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, srk-l0cyMroinI0@public.gmane.org, khilman-l0cyMroinI0@public.gmane.org, chinyeow.sim.xt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-input@vger.kernel.org On Thu, Mar 24, 2011 at 1:20 AM, Mark Brown wrote: > On Thu, Mar 24, 2011 at 01:04:31AM +0900, Magnus Damm wrote: > >> Sounds nice. Hopefully that will allow us to use module_init() in >> drivers instead of other initcall levels depending on bus type. > > None of this is anything to do with the bus type - it's to do with th= e > function of the devices within the system. =A0Things that are require= d for > early init of the kernel get bumped up the list. Hm, sorry for being unclear - I should have used the words "other initcall levels depending on the init order of the parent hardware bus". I'm referring to the state of things now without any patches from Grant. I understand that early init code often are using different initcall levels to make sure they are getting initialized before other code. Initcalls can also be used to work around link order issues. I can't however see the reason why a keypad driver needs to be initialized early on. I may be wrong, but I thought user space was the only consumer of input devices? / magnus