Re: [PATCH 0/4] Pegatron Lucid tablet acceleromter/ALS

[Corentin Chary <corentin.chary@gmail.com>]

On Tue, Jan 25, 2011 at 12:05 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Mon, Jan 24, 2011 at 02:48:04PM -0800, Andy Ross wrote:
>> Resubmission and update of the Pegatron Lucid tablet accelerometer and
>> ambient light sensor drivers.
>>
>> Patches 1-3 are against asus-laptop, and apply in order.
>>
>> Patch 4 is against input, and can be commited separately (obviously
>> relies on the detection code in asus-laptop at runtime, but will build
>> and load independently).
>>
>
> I am happy with the input part but I wonder if it really needs to be
> separate? If you roll it up into asus-laptop you would not need a new
> platform device and then it would be what - 20 lines of code?
>
> Corentin, what do you think?

I think that it should be consistent, if there is already some code
for pegatron tablet in asus-laptop, then why a new platform device
only for the accelerometer ?

On the other side, having to load "asus-laptop" on a pegatron tablet
(or on a lenovo laptop) isn't very intuitive.

The real name of this module should be atk010x_acpi, but it's not
really better, and it's probably too late for that.

Andy, what is shared with asus-laptop exactly ? What sysfs files are
working and enabled ?
Are backlight and led classes working ?

Thanks,
-- 
Corentin Chary
http://xf.iksaif.net