Re: [PATCH] hid-multitouch: changes from the review process

[Benjamin Tissoires <benjamin.tissoires@enac.fr>]

On Tue, Jan 11, 2011 at 3:00 PM, Benjamin Tissoires
<benjamin.tissoires@enac.fr> wrote:
> On Tue, Jan 11, 2011 at 2:11 PM, Henrik Rydberg <rydberg@bitmath.org> wrote:
>> [...]
>>> +             .sn_move = 0,
>>> +             .sn_pressure = 0,
>>> +             .maxcontacts = 10 },
>>> +     { .name = MT_CLS_DUAL1,
>>> +             .quirks = MT_QUIRK_SLOT_IS_CONTACTID,
>>> +             .sn_move = 0,
>>> +             .sn_pressure = 0,
>>> +             .maxcontacts = 2 },
>>> +     { .name = MT_CLS_DUAL2,
>>> +             .quirks = MT_QUIRK_SLOT_IS_CONTACTNUMBER,
>>> +             .sn_move = 0,
>>> +             .sn_pressure = 0,
>>> +             .maxcontacts = 2 },
>>> +     { .name = MT_CLS_CYPRESS,
>>> +             .quirks = MT_QUIRK_CYPRESS,
>>> +             .sn_move = 0,
>>> +             .sn_pressure = 0,
>>> +             .maxcontacts = 10 },
>>> +
>>> +     { }
>>>  };
>>
>> So no device is marked as NOT_SEEN_MEANS_UP, although allegedly some devices should...
>
> Well, my fault: I was sure that Cypress devices need the
> NOT_SEEN_MEANS_UP, but in fact, it was another one. We (with Stephane)
> don't recall it at the moment, but Stephane already saw some devices
> that required this quirk.
>
> mea culpa

I was neither wrong, neither right:
For cypress, TipSwitch, Confidence, and InRange always are the same... ;)
-> I'll need to put them with the quirk MT_NOT_SEEN_MEANS_UP

Cheers,
Benjamin
>
>>
>>[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html