From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B765137F005 for ; Wed, 17 Jun 2026 19:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781723100; cv=none; b=A5p/k+nGOm8aTJJFSvO/9KYK7eHGvBvEafTCi37lx3+6KtDDO9qHY10Po2nOpGxO8T0/J9nm3xJ3GM6kWx75XsmiP8sFmyoCP1hwsG4zSx0jdxblP7qwddhVaGnFiMBu7GwitHK5GeMhRqCcJUCnv8rQZ1Ib1v+UPCVZy1pcLFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781723100; c=relaxed/simple; bh=u+UvYY9UrxxjoueL+zkhTKOfBiuOgVDHJZSucBSfauU=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=KJrNMbdDeCBBqbYtI1rvbE43GsVXQL4IAwlqEtbj3onu93JojXgGZtPp0BN4o3d4bbl6OX0inPcF7OtNwEVr5OmObvKMc9yBbE5qEtXJGBZ1x9KmVNsmQiCeikXQSPng9jOgVWNdj81z0swF7e90LCJfUZx9Jgz0cVGcL6KYLcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kN58Hflz; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kN58Hflz" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf2247e38eso1689895ad.3 for ; Wed, 17 Jun 2026 12:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781723099; x=1782327899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=WWb5EDD7Z8+iTmdCvkmtSJcYVuqqEa89gpURDIob5KI=; b=kN58HflzSk4liSYDXCwGuR0rcdjrHhNVrOeSg3hYJWgXpbxe8v/RbKjdOS9IclQ8gq 2gTcPqrNAXXo6mP0icuMms/ZqaaQCN9EBT7F6xajDqK9ApSKWL1o7d0nwQlrVppIEAfq YV6bQH5yxgpQa5+FOf4yCZ1ZLsGvGGFyKPp9YFUHg53rleFLEmyhW95bxkBNDZlX1GKO UUoN4EcFcGhrh3HQqPgJy+cnwJtzSK8ZV89b4SxcKJZqP/PfLRKRMKEDpWP3A+QJdCUl HwgQAPvK5yvXFcAH7JmK8auj0/ZD2/R3qW0PEWm/KPZfg9QuRO6u4PX36AkyAAh6cTya SyUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781723099; x=1782327899; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WWb5EDD7Z8+iTmdCvkmtSJcYVuqqEa89gpURDIob5KI=; b=Asf2zMAT/Me7GhCP6XjXhQwaw3pJoVCs/dKBiHZIw81m5E5lZu1vGcLLbKQbQZIPgM vkF4Oeq1/2/DB2jqiVNmnvmMYcfw0bXatjFrISAYbvCs3eU0acSv/VjQgAv99DJcNZjw jqO1Ej/v91BuVKxgzjhhhtx4eZMr5w5XMuhMUqZYh16m7qi61quAsXP71MKuKV+LynDS X/co7sGszhKpHehSM0n3cvkv1rQeh/fok5zaT5raf367UnEMvb0qBL9ZetNjkqN3E7tt 0HLbdXX5302h0506iJB83VFbTpd4vBBiIfx4M1gJVQCbDIyekNyz1DyxpKcJ+gJHimuw 9f4g== X-Forwarded-Encrypted: i=1; AFNElJ9YZX8WOSV1lSZsZQ8ruRrICK1borXXZSE/GlSJq/5c6VjoM+2VN6OAkaecPbol590D2bFxzWuGCkD2QA==@vger.kernel.org X-Gm-Message-State: AOJu0Ywo13K1NmyQBw7lrSRrpIgvSrLEmJq90CpsXOIxHQk03IQoDanJ 033M1Onhk/by8K+m0VWtyH95YmeUjReJkuHcgsnXOhXLzqkYzvdorBWe X-Gm-Gg: AfdE7cmrAkj7zSEd9KlLUIxwkezZtyNM/JuMDGkentDE/V31ISnqKJayuyJ4rjgwM6l o4OKbNUyYLqGHrLPq6J4aDks3SC73+Q62ZX99bs2xlQqq2G8XknvweTPstf5mYLNI+EOWUmWrbh RMP5po2/fWGL6suabs7YgT/JxuLC/jQFTOsszvTnHOsdRzcxavj+iHTWOKGkVHs74uDqERyeO+t I+DovKXC/TiaEu6le5bg3UtmM0EHonKNBfpwVWJsdoKKQKagphKiQJs1BE1U9/pixP7Z4jy89tc KTixkzV2/tv6Pe5TTr04SDehecCtGio7aBo0Gi8FTmWdfy6oN8r6v5DSFmQl/6GUybxjR8Y/L+z l45OXXuVqZeeRmr7kAHYnbZHwtrbT8EgWLWrob83dDC4B3O1UMrNHjv/w2Ke55uaSOlcdfVcQx0 7aBPk0pJavvIRzQtUj93KFmpvIffmn3qSCJ+E= X-Received: by 2002:a17:903:950:b0:2c6:b816:43ba with SMTP id d9443c01a7336-2c6bc21ee45mr52773185ad.21.1781723098901; Wed, 17 Jun 2026 12:04:58 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:1f3f:6e5a:a26:1f1f:d75c:bc14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327ac80asm155502625ad.39.2026.06.17.12.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 12:04:56 -0700 (PDT) Date: Thu, 18 Jun 2026 00:33:09 +0530 From: Sanjay Chitroda To: Maxwell Doose CC: Jonathan Cameron , David Lechner , =?ISO-8859-1?Q?Nuno_S=E1?= , Andy Shevchenko , Jiri Kosina , Srinivas Pandruvada , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Zhang Lixu Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_00/11=5D_HID=3A_iio=3A_warning_c?= =?US-ASCII?Q?lean_up_and_prefer_kernel_coding_style?= User-Agent: Thunderbird for Android In-Reply-To: References: <20260616-15-jun-hid-iio-alignment-v1-0-0cd544286575@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 17 June 2026 1:00:37=E2=80=AFpm IST, Maxwell Doose wrote: >On Tue, Jun 16, 2026 at 5:26=E2=80=AFAM Sanjay Chitroda > wrote: >> >> Hi all, >> >> This series updates HID IIO drivers to resolve checkpatch and >> kernel coding style issue=2E >> >> This improves readability and follow standard kernel coding style >> No functional changes are introduced=2E >> >> Testing: >> - Compiled with W=3D1 for each patch in the series >> >> --- >> Sanjay Chitroda (11): >> iio: hid-sensors: add missing blank line after declarations >> iio: humidity: hid-sensor-humidity: align parenthesis for readabi= lity >> iio: gyro: hid-sensor-gyro-3d: align parenthesis for readability >> iio: magnetometer: hid-sensor-magn-3d: align parenthesis for read= ability >> iio: humidity: hid-sensor-humidity: use common device for devres >> iio: position: hid-sensor-custom-intel-hinge: use common device f= or devres >> iio: temperature: hid-sensor-temperature: use common device for d= evres >> iio: hid-sensor-magn-3d: use ! instead of explicit NULL check >> iio: hid-sensor-rotation: use ! instead of explicit NULL check >> iio: hid-sensor-incl-3d: use ! instead of explicit NULL check >> iio: hid-sensor-accel-3d: use ! instead of explicit NULL check >> >> drivers/iio/accel/hid-sensor-accel-3d=2Ec | 2 +- >> =2E=2E=2E/iio/common/hid-sensors/hid-sensor-trigger=2Ec | 3 + >> drivers/iio/gyro/hid-sensor-gyro-3d=2Ec | 58 ++++++++----= ---- >> drivers/iio/humidity/hid-sensor-humidity=2Ec | 48 ++++++------= - >> drivers/iio/magnetometer/hid-sensor-magn-3d=2Ec | 80 +++++++++++-= ---------- >> drivers/iio/orientation/hid-sensor-incl-3d=2Ec | 2 +- >> drivers/iio/orientation/hid-sensor-rotation=2Ec | 2 +- >> =2E=2E=2E/iio/position/hid-sensor-custom-intel-hinge=2Ec | 2 +- >> drivers/iio/temperature/hid-sensor-temperature=2Ec | 4 +- >> 9 files changed, 102 insertions(+), 99 deletions(-) > >Firstly, for all of the style patches (1-4, 8-11): > >Reviewed-by: Maxwell Doose > Hi Maxwell, Thank you for the review=2E >with Andy's comments=2E > >Secondly, the style fixes are all churn=2E It would honestly be much >much better if you were to squash those (even despite the >one-logical-change-per-patch rule)=2E I agree with squashing 1-4, common HID drivers-specific changes which cove= r all HID IIO drivers=2E However, this series updates 4 HID drivers, while several other HID IIO dr= ivers needs coding style cleanup=2E I'd like to ask Jonathan for his opinion on whether all alignment coding s= tyle should be handled in single change, individual change or some logic sp= ecific HIO IIO drivers split=2E Additionally, 5-7 haven't received any comment/tag=2E I can consider all c= hanges in v2 and also rebase on latest iio/testing tree to incorporate u32 = usage_id change=2E Thanks, Sanjay >