From: Amit Nagal <helloin.amit@gmail.com>
To: linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>
Subject: list not released in case of -ENODEV in hidraw_release (hidraw.c)
Date: Wed, 22 Jun 2011 13:28:26 +0530 [thread overview]
Message-ID: <BANLkTi=Teg9iN8osSDY9fqadZ+sA-Ng2Sw@mail.gmail.com> (raw)
Hi ,
linux kernel ver 2.6.39.1 , hidraw.c , in hidraw_release function
, list pointer ( struct hidraw_list *list ) is not freed
in case of -ENODEV .
i think the following patch is applicable :
--- a/drivers/hid/hidraw.c 2011-06-22 08:57:55.000000000 -0400
+++ b/drivers/hid/hidraw.c 2011-06-22 08:42:04.000000000 -0400
@@ -298,6 +298,7 @@ static int hidraw_release(struct inode *
mutex_lock(&minors_lock);
if (!hidraw_table[minor]) {
+ kfree(list);
ret = -ENODEV;
goto unlock;
}
Please correct me if i am mistaken .
Regards
Amit Nagal
next reply other threads:[~2011-06-22 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 7:58 Amit Nagal [this message]
[not found] ` <BANLkTi=Teg9iN8osSDY9fqadZ+sA-Ng2Sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-22 11:43 ` list not released in case of -ENODEV in hidraw_release (hidraw.c) Amit Nagal
2011-07-22 14:36 ` Jiri Kosina
2011-07-27 4:03 ` Amit Nagal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=Teg9iN8osSDY9fqadZ+sA-Ng2Sw@mail.gmail.com' \
--to=helloin.amit@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).