From: Daniel Mack <zonque@gmail.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 0/2] input: rotary-encoder: add support for half-period encoders
Date: Fri, 8 Apr 2011 09:39:21 +0200 [thread overview]
Message-ID: <BANLkTimw=tiCn2gbVg7DCqe2ydexgByuEQ@mail.gmail.com> (raw)
In-Reply-To: <1302027313-27130-1-git-send-email-jhovold@gmail.com>
On Tue, Apr 5, 2011 at 8:15 PM, Johan Hovold <jhovold@gmail.com> wrote:
> Hi,
>
> These patches add support for rotary-encoders which have two stable states per
> input signal period.
>
> The first patch refactors state retrieval and event reporting and the second
> adds support for such half-period encoders.
I have no objections to let the code in, and the patch looks sane to me.
However, I don't currently have access to the hardware I wrote the
driver for, so I can't test right now, but will do at some later
point.
Feel free to add my Acked-by:, and I will get back to you in case I
encounter any trouble.
Thanks,
Daniel
next prev parent reply other threads:[~2011-04-08 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 18:15 [PATCH 0/2] input: rotary-encoder: add support for half-period encoders Johan Hovold
2011-04-05 18:15 ` [PATCH 1/2] input: rotary-encoder: refactor and clean up Johan Hovold
2011-04-06 23:30 ` H Hartley Sweeten
2011-04-05 18:15 ` [PATCH 2/2] input: rotary-encoder: add support for half-period encoders Johan Hovold
2011-04-05 19:39 ` [PATCH 2/2 v2] " Johan Hovold
2011-04-05 19:46 ` [PATCH 2/2 v3] " Johan Hovold
2011-04-08 7:39 ` Daniel Mack [this message]
2011-04-11 10:44 ` [PATCH 0/2] " Johan Hovold
2011-05-10 19:05 ` Johan Hovold
2011-05-22 21:29 ` Daniel Mack
2011-05-22 22:42 ` Daniel Mack
2011-05-23 12:07 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimw=tiCn2gbVg7DCqe2ydexgByuEQ@mail.gmail.com' \
--to=zonque@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jhovold@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).