linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chih-Wei Huang <cwhuang@android-x86.org>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	linux-input@vger.kernel.org
Subject: Re: ET1602 Touchscreen doesn't work
Date: Wed, 8 Jun 2011 22:56:29 +0800	[thread overview]
Message-ID: <BANLkTin1YhxCE5J9suR93eWcWEtviFNLtg@mail.gmail.com> (raw)
In-Reply-To: <20110608125758.GA2465@nautilus.holoscopio.com>

Thanks, Benjamin and Cascardo.

2011/6/8 Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>:
> Thanks, Benjamin. That clarifies a lot and points what the real fix
> should be for this device.
> Chih-Wei, could you send us the results of your tests? I don't have the
> device available right now. I could get it next week, perhaps, if my
> client still gets it.

I'm glad to do so.
But what test results did you want me to show exactly?

Let me clarify my situation:
* Device under test: ASUS ET1602, touchscreen id (1bfd:1688).
* Kernel: 2.6.38, with android patches (from Google)
* Android version: 2.2.2 (froyo)

By the previous observation from getevent, I added
the following patch to android framework:

diff --git a/libs/ui/EventHub.cpp b/libs/ui/EventHub.cpp
index 0e11823..6ef9da1 100755
--- a/libs/ui/EventHub.cpp
+++ b/libs/ui/EventHub.cpp
@@ -670,7 +671,7 @@ int EventHub::open_device(const char *deviceName)
         device->classes |= CLASS_TOUCHSCREEN | CLASS_TOUCHSCREEN_MT;

     // Is this an old style single-touch driver?
-    } else if (test_bit(BTN_TOUCH, key_bitmask)
+    } else if ((test_bit(BTN_TOUCH, key_bitmask) ||
test_bit(BTN_MOUSE, key_bitmask))
             && test_bit(ABS_X, abs_bitmask) && test_bit(ABS_Y, abs_bitmask)) {
         device->classes |= CLASS_TOUCHSCREEN;
     }

Then the touch device (event7) is correctly recognized by
the android framework and works fine.

Without this patch, event7 is ignored and only event6 is detected,
but no touch event generated from it.

Let me know if you need more details.

I'll try Benjamin's suggestion tomorrow.

Regards,
-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org

  reply	other threads:[~2011-06-08 14:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BANLkTikX9njth-jP6PpQuwL9sTUciu1nQA@mail.gmail.com>
2011-06-02 14:41 ` ET1602 Touchscreen doesn't work Thadeu Lima de Souza Cascardo
2011-06-03  4:02   ` Chih-Wei Huang
2011-06-03 12:44     ` Thadeu Lima de Souza Cascardo
2011-06-08 10:33       ` Chih-Wei Huang
2011-06-08 11:31         ` Benjamin Tissoires
2011-06-08 12:57           ` Thadeu Lima de Souza Cascardo
2011-06-08 14:56             ` Chih-Wei Huang [this message]
2011-06-08 15:31               ` Thadeu Lima de Souza Cascardo
2011-06-09 11:26                 ` Chih-Wei Huang
2011-06-09 13:39                   ` Thadeu Lima de Souza Cascardo
2011-06-10  2:23                     ` Chih-Wei Huang
2011-06-13 15:09                       ` Thadeu Lima de Souza Cascardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTin1YhxCE5J9suR93eWcWEtviFNLtg@mail.gmail.com \
    --to=cwhuang@android-x86.org \
    --cc=benjamin.tissoires@gmail.com \
    --cc=cascardo@holoscopio.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).