From: Benjamin Tissoires <benjamin.tissoires@enac.fr>
To: Austin Zhang <zhang.austin@gmail.com>
Cc: "Stéphane Chatty" <chatty@enac.fr>,
"Henrik Rydberg" <rydberg@euromail.se>,
linux-input@vger.kernel.org, jkosina@suse.cz,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH]HID: hid-multitouch: add support for Chunghwa multi-touch panel
Date: Fri, 27 May 2011 10:48:25 +0200 [thread overview]
Message-ID: <BANLkTin3jqYUASnW+wExAHd2YCBqB2j9Uw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=52uMg4Ut2Bs5VbgSeRO4wJeLgHw@mail.gmail.com>
Hi,
The patch has been corrupted by your mail client.
Please use git send-email to resend it.
Please also add the authors of the driver (me and Stéphane Chatty) and
the MT maintainer (Henrik Rydberg).
If the patch does not mismatch tabs and spaces, you can have my Reviewed-by.
Cheers,
Benjamin
On Fri, May 27, 2011 at 10:20, Austin Zhang <zhang.austin@gmail.com> wrote:
> Added Chunghwa hid multitouch panel support into hid-multitouch.
>
> Signed-off-by: Austin Zhang <zhang.austin@gmail.com>
> ---
> Kconfig | 1 +
> hid-core.c | 1 +
> hid-ids.h | 3 +++
> hid-multitouch.c | 5 +++++
> 4 files changed, 10 insertions(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 67d2a75..36ca465 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -305,6 +305,7 @@ config HID_MULTITOUCH
> - 3M PCT touch screens
> - ActionStar dual touch panels
> - Cando dual touch panels
> + - Chunghwa panels
> - CVTouch panels
> - Cypress TrueTouch panels
> - Elo TouchSystems IntelliTouch Plus panels
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index c957c4b..f7440e8 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1359,6 +1359,7 @@ static const struct hid_device_id
> hid_have_special_driver[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_CHERRY,
> USB_DEVICE_ID_CHERRY_CYMOTION_SOLAR) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY,
> USB_DEVICE_ID_CHICONY_TACTICAL_PAD) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY,
> USB_DEVICE_ID_CHICONY_WIRELESS) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_CHUNGHWAT,
> USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CREATIVELABS,
> USB_DEVICE_ID_PRODIKEYS_PCMIDI) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CVTOUCH, USB_DEVICE_ID_CVTOUCH_SCREEN) },
> { HID_USB_DEVICE(USB_VENDOR_ID_CYPRESS,
> USB_DEVICE_ID_CYPRESS_BARCODE_1) },
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 0b374a6..82be975 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -173,6 +173,9 @@
> #define USB_DEVICE_ID_CHICONY_MULTI_TOUCH 0xb19d
> #define USB_DEVICE_ID_CHICONY_WIRELESS 0x0618
>
> +#define USB_VENDOR_ID_CHUNGHWAT 0x2247
> +#define USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH 0x0001
> +
> #define USB_VENDOR_ID_CIDC 0x1677
>
> #define USB_VENDOR_ID_CMEDIA 0x0d8c
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index ecd4d2d..8bc32a0 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -593,6 +593,11 @@ static const struct hid_device_id mt_devices[] = {
> HID_USB_DEVICE(USB_VENDOR_ID_CANDO,
> USB_DEVICE_ID_CANDO_MULTI_TOUCH_15_6) },
>
> + /* Chunghwa Telecom touch panels */
> + { .driver_data = MT_CLS_DEFAULT,
> + HID_USB_DEVICE(USB_VENDOR_ID_CHUNGHWAT,
> + USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH) },
> +
> /* CVTouch panels */
> { .driver_data = MT_CLS_DEFAULT,
> HID_USB_DEVICE(USB_VENDOR_ID_CVTOUCH,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-27 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 8:20 [PATCH]HID: hid-multitouch: add support for Chunghwa multi-touch panel Austin Zhang
2011-05-27 8:48 ` Benjamin Tissoires [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-27 18:03 Austin Zhang
2011-05-27 18:10 ` Benjamin Tissoires
2011-06-07 13:43 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin3jqYUASnW+wExAHd2YCBqB2j9Uw@mail.gmail.com \
--to=benjamin.tissoires@enac.fr \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=zhang.austin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).