From: David Herrmann <dh.herrmann@googlemail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, padovan@profusion.mobi
Subject: Re: [RFC 05/12] HID: wiimote: Synchronize wiimote input and hid event handling
Date: Thu, 16 Jun 2011 12:29:40 +0200 [thread overview]
Message-ID: <BANLkTinwT3CSwkiytCoVbb4Q6UMzDx8tag@mail.gmail.com> (raw)
In-Reply-To: <201106161218.55279.oneukum@suse.de>
On Thu, Jun 16, 2011 at 12:18 PM, Oliver Neukum <oneukum@suse.de> wrote:
> Am Donnerstag, 16. Juni 2011, 11:20:18 schrieb Jiri Kosina:
>> > Here an smp_wmb()
>> > It is redundant because input_register_device takes a spinlock which
>> > implies a barrier, but you'll make the automated checking tools happier.
>>
>> Yeah, spinlock implies SMP barrier implicitly.
>>
>> I don't think adding barriers just to make some buggy automatic checker
>> happy is worth it.
>
> Fine by me as long as the problem is understood.
Does that mean that I can omit the smp_rmb(), too? I do not like
relying on input_register_device to use a spinlock. It makes reading
the code hard, so I added both barriers. Should I remove them again or
keep them?
Thank you for reviewing. I have fixed all your concerns. I will resend
the patches if there are no more comments on the code as [PATCH] in
few days.
Regards
David
next prev parent reply other threads:[~2011-06-16 10:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 23:45 [RFC 00/12] Nintendo Wii Remote Device Driver David Herrmann
2011-06-14 23:45 ` [RFC 01/12] HID: wiimote: Add Nintendo Wii Remote driver stub David Herrmann
2011-06-14 23:45 ` [RFC 02/12] HID: wiimote: Register wiimote hid " David Herrmann
2011-06-14 23:45 ` [RFC 03/12] HID: wiimote: Add wiimote device structure David Herrmann
2011-06-15 6:20 ` Oliver Neukum
2011-06-14 23:45 ` [RFC 04/12] HID: wiimote: Register input device in wiimote hid driver David Herrmann
2011-06-14 23:45 ` [RFC 05/12] HID: wiimote: Synchronize wiimote input and hid event handling David Herrmann
2011-06-15 6:34 ` Oliver Neukum
2011-06-16 9:20 ` Jiri Kosina
2011-06-16 10:18 ` Oliver Neukum
2011-06-16 10:29 ` David Herrmann [this message]
2011-06-16 10:42 ` Oliver Neukum
2011-06-14 23:45 ` [RFC 06/12] HID: wiimote: Add wiimote send function David Herrmann
2011-06-14 23:45 ` [RFC 07/12] HID: wiimote: Add output queue for wiimote driver David Herrmann
2011-06-15 6:37 ` Oliver Neukum
2011-06-14 23:45 ` [RFC 08/12] HID: wiimote: Add wiimote event handler David Herrmann
2011-06-14 23:45 ` [RFC 09/12] HID: wiimote: Add wiimote input button parser David Herrmann
2011-06-14 23:45 ` [RFC 10/12] HID: wiimote: Add wiimote led request David Herrmann
2011-06-14 23:45 ` [RFC 11/12] HID: wiimote: Cache wiimote led state David Herrmann
2011-06-15 6:40 ` Oliver Neukum
2011-06-14 23:45 ` [RFC 12/12] HID: wiimote: Add sysfs support to wiimote driver David Herrmann
2011-06-16 18:35 ` Jiri Kosina
2011-06-17 14:58 ` David Herrmann
2011-06-16 18:36 ` [RFC 00/12] Nintendo Wii Remote Device Driver Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinwT3CSwkiytCoVbb4Q6UMzDx8tag@mail.gmail.com \
--to=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).