From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dudley Du Subject: RE: [PATCH v16 00/12] input: cyapa: instruction of cyapa patches Date: Wed, 17 Dec 2014 18:03:47 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from bay004-omc1s8.hotmail.com ([65.54.190.19]:59433 "EHLO BAY004-OMC1S8.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbaLQKDt convert rfc822-to-8bit (ORCPT ); Wed, 17 Dec 2014 05:03:49 -0500 In-Reply-To: Content-Language: zh-cn Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: dmitry.torokhov@gmail.com, jmmahler@gmail.com, rydberg@euromail.se Cc: bleung@google.com, 'David Solda' , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dudley Du Jmmahler, Thank you very much for your review and comments based on v15 patches. I have modified all points based on your comments and generate this v16= patches. Could you please help review again when have time. By the way, since gmail is blocked again in my side, so I use private e= mail dudlx@outlook.com instead to send these patches manually. Thanks, Dudley > -----Original Message----- > From: Dudley Du [mailto:dudlx@outlook.com] > Sent: 2014=C4=EA12=D4=C217=C8=D5 17:55 > To: dmitry.torokhov@gmail.com; jmmahler@gmail.com; rydberg@euromail.s= e > Cc: bleung@google.com; David Solda; linux-input@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: [PATCH v16 00/12] input: cyapa: instruction of cyapa patches >=20 > V16 patches have below updates, details of other updates see history = list: > 1) Fix all miss-spelling and space issue. > 2) Rename variables and functions with much more clearer names. > 3) Initialize and document tries near where it will be used. > 4) Modify cmd buffer to struct for more descriptive way. >=20 >=20 > This patch series is aimed to re-design the cyapa driver to support > old gen3 trackpad devices and new gen5 trackpad devices in one > cyapa driver, it's for easily productions support based on > customers' requirements. And add sysfs functions and interfaces > supported that required by users and customers. >=20 > Since the earlier gen3 and the latest gen5 trackpad devices using > two different chipsets, and have different protocols and interfaces, > so if supported these two type trackpad devices in two different driv= ers, > then it will be difficult to manage productions and later firmware up= dates. > e.g.: It will cause customer don't know which one trackpad device fir= mware > image to use and update when it has been used and integrated > in same one productions, so here we support these two trackpad > devices in same on driver. >=20 > The new design cyapa driver contains: > cyapa.c - the core of the re-design, supply interfaces and > functions to system and read trackpad devices. > cyapa.h - header file including macros and data structure definitions= =2E > cyapa_gen3.c - functions support for gen3 trackpad devices, > cyapa_gen5.c - functions support for gen5 trackpad devices. >=20 > Beside this introduction patch, it has 12 patches listed as below. > For these patches, each one is patched based on previous one. >=20 > patch 1/12: re-design cyapa driver with core functions and interface > to support multi-type trackpad devices. >=20 > patch 2/12: add gen5 trackpad device basic functions support in the > re-design cyapa driver. >=20 > patch 3/12: add power management interfaces support for the device. >=20 > patch 4/12: add runtime power management interfaces support for the d= evice. >=20 > patch 5/12: add sysfs interfaces supported in the cyapa driver. > Including read firmware version, get production ID, read baseline, > re-calibrate trackpad baselines and do trackpad firmware update. >=20 > patch 6/12: add gen3 trackpad device's firmware update function suppo= rt. >=20 > patch 7/12: add gen3 trackpad device's read baseline function support= =2E >=20 > patch 8/12: add gen3 trackpad device's force re-calibrate function su= pport. >=20 > patch 9/12: add gen5 trackpad device's firmware update function suppo= rt. >=20 > patch 10/12: add gen5 trackpad device's read baseline function suppor= t. >=20 > patch 11/12: add gen5 trackpad device's force re-calibrate function. >=20 > patch 12/12: add acpi device id support. >=20 >=20 > History patch series modifications list: > V15 patches have below main updates compared with v14 patches: > 1) Fix all warning errors of sparse tool when running with "make C=3D= 1". > 2) Change variable name "unique_str" to "product_id" for clearer mean= ings. > 3) Update cyapa_i2c_write function to return error directly when leng= th > 31. >=20 > V14 patches have below main updates compared with v13 patches: > 1) Correct 9 miss spelling issues of "bufferred" to "buffered". > 2) Fix the upgrade issue of removing MOUSE_CYAPA config when make old= config > by replase "depends on I2C && CRC_ITU_T" with > "depends on I2C" > "select CRC_ITU_T" > in patch 9. >=20 > V13 patches have below main updates compared with v12 patches: > 1) Remove all debugfs interface, including read_fw and raw_data inter= faces. > 2) This patches are made based linux next-20141208. >=20 > V12 patches have below main updates compared with v11 patches: > 1) Add check that when TP is detected but not operational, do not exi= t driver > immediately, but wait and export the update_fw interface for recov= ering. > 2) Re-arrange the function codes, remove unnesseary protype definitio= ns in > the header file. >=20 > V11 patches have below main updates compared with v10 patches: > 1) Add add acpi device id supported for old gen3 and new gen5 trackpa= d devices. > 2) Fix the unable to update firmware issue when cyapa_open is not cal= led > which means the irq for firwmare update process is not enabled. Th= is fix > by checking if the irq is enabled, if not then enable irq before s= tart to > do firmware update. >=20 > V10 patches have below main updates compared with v9 patches: > 1) Modify code to following kernel code style. > e.g.: correct to use error as return name when there is only error= path, > and fix the checkpatch.sh wanting in the driver. > 2) Remove cyapa_remove method and use input open and close interface = to > following device resouse management infrastructure. > 3) Modify cyapa_detect method to return tristate issue to make the re= turn value > much more consistent and clear. > 4) Use platform supplied functions as possible instead of driver > specific rewritten version. >=20 > V9 patches have below updates compared with v8 patches: > 1) Removed all async thread stuff from the driver. > 2) Split driver into 18 patches for each function change one patch. >=20 > V8 patches have below updates compared with v7 patches: > 1) [PATCH v8 01/13] - Remove the async thread for device detect in > probe routine, now the device detect process is completely done wi= thin > the device probe routine. > 2) [PATCH v8 01/13] - Split the irq cmd hander function to separated > function cyapa_default_irq_cmd_handler() and set it to interface > cyapa_default_ops.irq_cmd_handler. > 3) [PATCH v8 06/13] - Add cyapa->gen check in cyapa_gen3_irq_cmd_hand= ler() > to avoid miss-enter when device protocol is still in detecting. >=20 > V7 patches have below updates compared with v6 patches: > 1) [PATCH v7 01/13] - Split the irq cmd hander function to separated > function cyapa_default_irq_cmd_handler() and set it to interface > cyapa_default_ops.irq_cmd_handler. > 2) [PATCH v7 06/13] - Add cyapa->gen check in cyapa_gen3_irq_cmd_hand= ler() > to avoid miss-enter when device protocol is still in detecting. >=20 >=20 > V6 patches have below updates compared with v5 patches: > 1) Remove patch 14 of the lid filtering from the cyapa driver. >=20 > V5 patches have below updates compared with v4 patches: > 1) Uses get_device()/put_device() instead of kobject_get()/kobject_pu= t(); > 2) Fix memories freed before debugfs entries issue; > 3) Make cyapa_debugs_root valid in driver module level > in module_init()/moudle_exit() ; > 4) Fix i2c_transfer() may return partial transfer issues. > 5) Add cyapa->removed flag to avoid detecting thread may still runnin= g > when driver module is removed. > 6) Fix the meanings of some comments and return error code not clear = issue. -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html