[PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

[PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

[WangYuli]

Modified keyboard_ids in function ps2_is_keyboard_id
for Lenovo Xiaoxin keyboard.

Signed-off-by: yuanjianye <yuanjianye@uniontech.com>
Signed-off-by: shaoyang <shaoyang@uniontech.com>
Reviewed-by: huangbibo <huangbibo@uniontech.com>
Signed-off-by: helugang <helugang@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 drivers/input/serio/libps2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
index 6d78a1fe00c1..39d46526c56a 100644
--- a/drivers/input/serio/libps2.c
+++ b/drivers/input/serio/libps2.c
@@ -189,6 +189,7 @@ bool ps2_is_keyboard_id(u8 id_byte)
 		0x5d,	/* Trust keyboard		*/
 		0x60,	/* NMB SGI keyboard, translated */
 		0x47,	/* NMB SGI keyboard		*/
+		0x83,	/* Lenovo Xiaoxin keyboard	*/
 	};
 
 	return memchr(keyboard_ids, id_byte, sizeof(keyboard_ids)) != NULL;
-- 
2.43.0

Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

[Dmitry Torokhov]

Hi,

On Tue, Mar 26, 2024 at 09:17:18PM +0800, WangYuli wrote:
> Modified keyboard_ids in function ps2_is_keyboard_id
> for Lenovo Xiaoxin keyboard.
> 
> Signed-off-by: yuanjianye <yuanjianye@uniontech.com>
> Signed-off-by: shaoyang <shaoyang@uniontech.com>
> Reviewed-by: huangbibo <huangbibo@uniontech.com>
> Signed-off-by: helugang <helugang@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  drivers/input/serio/libps2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
> index 6d78a1fe00c1..39d46526c56a 100644
> --- a/drivers/input/serio/libps2.c
> +++ b/drivers/input/serio/libps2.c
> @@ -189,6 +189,7 @@ bool ps2_is_keyboard_id(u8 id_byte)
>  		0x5d,	/* Trust keyboard		*/
>  		0x60,	/* NMB SGI keyboard, translated */
>  		0x47,	/* NMB SGI keyboard		*/
> +		0x83,	/* Lenovo Xiaoxin keyboard	*/

Could you please tell me more about the keyboard? What ID does it use?
Majority of keyboards are using 0xab83, does your device forget to send
0xab by chance?

Thanks.

-- 
Dmitry

Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

[WangYuli]

Hi,

On 2024/3/29 04:34, Dmitry Torokhov wrote:
> Could you please tell me more about the keyboard?

Link: 
https://lore.kernel.org/lkml/20230514083336.3811-1-yesh25@mail2.sysu.edu.cn/T/

Link: https://gist.github.com/yescallop/5a97d010f226172fafab0933ce8ea8af

Those links above mentioned the same situation.

Lenovo has a batch of laptops shipped in 2021 with the same problem. And

the combined sales of these products are considerable.

> What ID does it use?
0x83.
> Majority of keyboards are using 0xab83, does your device forget to send
> 0xab by chance?
Unfortunalety, I'm afraid not.
>
> Thanks.
>
Thanks.

-- 

WangYuli

Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

[Shang Ye]

Hi,

On 2024/04/18 4:16 pm, WangYuli wrote:
> Hi,
>
> On 2024/3/29 04:34, Dmitry Torokhov wrote:
>> Could you please tell me more about the keyboard?
>
> Link: 
> https://lore.kernel.org/lkml/20230514083336.3811-1-yesh25@mail2.sysu.edu.cn/T/
>
> Link: https://gist.github.com/yescallop/5a97d010f226172fafab0933ce8ea8af
>
> Those links above mentioned the same situation.
>
> Lenovo has a batch of laptops shipped in 2021 with the same problem. And
>
> the combined sales of these products are considerable.
>
>> What ID does it use?
> 0x83.
>> Majority of keyboards are using 0xab83, does your device forget to send
>> 0xab by chance?
> Unfortunalety, I'm afraid not.
>>
>> Thanks.
>>
> Thanks.
>
I'm pretty sure that the problem I encountered was already fixed by a 
previous patch:
https://lore.kernel.org/r/20231115174625.7462-1-hdegoede@redhat.com

Could you please check if it is the case?

Regards,
Shang