From: Amit Nagal <helloin.amit@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
Alan Ott <alan@signal11.us>,
Antonio Ospite <ospite@studenti.unina.it>
Subject: Re: list not released in case of -ENODEV in hidraw_release (hidraw.c)
Date: Wed, 27 Jul 2011 09:33:51 +0530 [thread overview]
Message-ID: <CA+F9FsDP3u9fe4HW8RSay_2Zxq_GJwrg2FLE74AJWCVjPMEtVQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1107221635550.7300@pobox.suse.cz>
On Fri, Jul 22, 2011 at 8:06 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Wed, 22 Jun 2011, Amit Nagal wrote:
>
>> > linux kernel ver 2.6.39.1 , hidraw.c , in hidraw_release function
>> > , list pointer ( struct hidraw_list *list ) is not freed
>> > in case of -ENODEV .
>> >
>> > i think the following patch is applicable :
>> >
>> > --- a/drivers/hid/hidraw.c 2011-06-22 08:57:55.000000000 -0400
>> > +++ b/drivers/hid/hidraw.c 2011-06-22 08:42:04.000000000 -0400
>> > @@ -298,6 +298,7 @@ static int hidraw_release(struct inode *
>> >
>> > mutex_lock(&minors_lock);
>> > if (!hidraw_table[minor]) {
>> > + kfree(list);
>> > ret = -ENODEV;
>> > goto unlock;
>> > }
>> >
>> > Please correct me if i am mistaken .
>> >
>>
>> In continuation of above , in hidraw_release(), for the sequence
>> disconnect followed by last userspace close(fd) call ,
>> even kfree(list->hidraw) should also be called , as in
>> hidraw_disconnect() function kfree(hidraw) is called only when
>> hidraw->open is 0 .
>> so list->hidraw should also be freed when calling last close() call
>> even after disconnect .
>
> Hi Amit,
>
> your analysis is correct. Could you please re-send the patch with the
> other fixes added, and also your Signed-off-by line?
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
Thanx for reviewing my analysis . i will resubmit the patch after
adding other fixes as well .
Regards
Amit Nagal
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-07-27 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 7:58 list not released in case of -ENODEV in hidraw_release (hidraw.c) Amit Nagal
[not found] ` <BANLkTi=Teg9iN8osSDY9fqadZ+sA-Ng2Sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-22 11:43 ` Amit Nagal
2011-07-22 14:36 ` Jiri Kosina
2011-07-27 4:03 ` Amit Nagal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+F9FsDP3u9fe4HW8RSay_2Zxq_GJwrg2FLE74AJWCVjPMEtVQ@mail.gmail.com \
--to=helloin.amit@gmail.com \
--cc=alan@signal11.us \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).