From: "Ezequiel García" <ezequiel@vanguardiasur.com.ar>
To: Daniel Mack <zonque@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v2 1/2] Input: rotary-encoder: Add 'stepped' irq handler
Date: Sat, 12 Oct 2013 13:58:59 -0300 [thread overview]
Message-ID: <CAAEAJfCmnMFWnSRcWN946fc615po4zAn0a-yUSUnYeTjObXr_w@mail.gmail.com> (raw)
In-Reply-To: <524EC022.2050203@gmail.com>
Dmitry,
On 4 October 2013 10:18, Daniel Mack <zonque@gmail.com> wrote:
> On 04.10.2013 14:53, Ezequiel Garcia wrote:
>> Some rotary-encoder devices (such as those with detents) are capable
>> of producing a stable event on each step. This commit adds support
>> for this case, by implementing a new interruption handler.
>>
>> The handler needs only detect the direction of the turn and generate
>> an event according to this detection.
>
> I think you can squash patch 2/2 into this one. It doesn't make much
> sense to have a one-liner patch to just update the documenation separately.
>
> Other than that, the code looks fine to me.
>
> Acked-by: Daniel Mack <zonque@gmail.com>
>
Could you merge these two patches?
It's already acked by Daniel, and there wasn't any other feedback
so I think we're ready to get them in and support more devices :-)
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-12 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 12:53 [PATCH v2 0/2] rotary-encoder: Add new interruption handler Ezequiel Garcia
2013-10-04 12:53 ` [PATCH v2 1/2] Input: rotary-encoder: Add 'stepped' irq handler Ezequiel Garcia
2013-10-04 13:18 ` Daniel Mack
2013-10-12 16:58 ` Ezequiel García [this message]
[not found] ` <1380891203-17617-1-git-send-email-ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
2013-10-04 12:53 ` [PATCH v2 2/2] input: rotary-encoder: Add 'on-each-step' to binding documentation Ezequiel Garcia
2013-10-04 13:19 ` Mark Rutland
2013-10-04 14:09 ` Ezequiel Garcia
2013-10-10 13:55 ` Ezequiel García
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAEAJfCmnMFWnSRcWN946fc615po4zAn0a-yUSUnYeTjObXr_w@mail.gmail.com \
--to=ezequiel@vanguardiasur.com.ar \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).