From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2552E7D0AA for ; Thu, 21 Sep 2023 21:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbjIUVNF (ORCPT ); Thu, 21 Sep 2023 17:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231603AbjIUVMX (ORCPT ); Thu, 21 Sep 2023 17:12:23 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51CF498A73 for ; Thu, 21 Sep 2023 10:56:52 -0700 (PDT) Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 912623F66F for ; Thu, 21 Sep 2023 06:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1695276528; bh=LGLvEUCLByX56ZHTlqmLlwmZ6pTbCna8gvztcJYDoU8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rauudwVUP8l7s8SwO4VSe69N7gnmCVEH1jsNY1fFoKehhXjOrLiPmAoeqI7widzy7 ZUxhg4oe+oHsZfKmL/AMw6mjza/a7C4z12xb4eiJ+dfy2KR5I2nipRDHlvAGbxCnWh canQ+lz3VdI78sZMi0Yr86AqHTZJxAVIREWSg5gLp6dut/4Ne+d7F4W7G8Xtw5M+jq IC6PBAWXzjBkgllANmR9e7E1ru5kZ0cJkRwgmeuSWpu/kP7PIlyLwPRCCZdh7Pb3Bs Y3VCQo9nYSaSkQcZC2VDeulP1/JUSxlpXKP4s509rTW/mPkfmwJ0hUIp87GeLa6yEs sEkFWaQd34ztQ== Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-5789f2f13fcso441938a12.3 for ; Wed, 20 Sep 2023 23:08:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695276527; x=1695881327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LGLvEUCLByX56ZHTlqmLlwmZ6pTbCna8gvztcJYDoU8=; b=SCuTMwV0C42dNCJqFMEsqeErbGKwDRepR95MuHYFRfCZIKNNwOIogd8OhFmhKxRcUK sbNfY9f+iC+BDNQpzcwJf15Gamwra/0QFyrGwn2IfsuCMELuAB26yHmyBmJMjsGdS32u RutAJaPLp50kn7rcAAKMbVpyHuCDcwrUNU1fdfgE6aVufNL1kPZIWh2GZDB+8f9rdn6J euHqH5ES8ycj858+vuh8kRIZ6voKi4TxtwWxGk+7E5SoEdt/SKB+PvO7c03TeaN2STvZ DQh1vasOBqaXE3w3RLGGI5PUFKufvhRZa4Bc1nfICjQx4Hagm2aM7D3x7QcqWZbA2q7I 2fPg== X-Gm-Message-State: AOJu0Ywf0LICv/gR49Yp+0vndIvwDNb2jRMCPz/n7lQpWj1mn4OSaVAm Y3qm5hUabNW7OSMaLI0oY8ungPS+WelvRJGHfRPP7HNpnw9HwPLAa1GmfT8Bl195G9kDWI1N9Jl NgQMCx+409ur8bLUxjwadTCVfedQSZ2lDF5lBYRr0+kpchZ9tzYSYMFQN X-Received: by 2002:a17:90b:60f:b0:271:9237:a07f with SMTP id gb15-20020a17090b060f00b002719237a07fmr4869855pjb.32.1695276527090; Wed, 20 Sep 2023 23:08:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3mcQsaQ+FE/ji4v4nyF6aUsilUttOw7YcXgkdZG82nw6jvzjNPhHOMNN3PnauJxNw7lKirmfAfZZ+zIWZCFI= X-Received: by 2002:a17:90b:60f:b0:271:9237:a07f with SMTP id gb15-20020a17090b060f00b002719237a07fmr4869844pjb.32.1695276526779; Wed, 20 Sep 2023 23:08:46 -0700 (PDT) MIME-Version: 1.0 References: <20230914041806.816741-1-kai.heng.feng@canonical.com> <7b45ac2ed091497b4e21a6a5c19956161175ba16.camel@linux.intel.com> <67c85f083201ed2cda2cab198b40141ad21912a2.camel@linux.intel.com> In-Reply-To: From: Kai-Heng Feng Date: Thu, 21 Sep 2023 14:08:33 +0800 Message-ID: Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Rework EHL OOB wakeup To: "Rafael J. Wysocki" Cc: srinivas pandruvada , "Xu, Even" , "jikos@kernel.org" , "benjamin.tissoires@redhat.com" , "linux-pm@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Lee, Jian Hui" , "Zhang, Lixu" , "Ba, Najumon" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Sep 20, 2023 at 2:00=E2=80=AFAM Rafael J. Wysocki wrote: > > On Tue, Sep 19, 2023 at 6:54=E2=80=AFPM srinivas pandruvada > wrote: > > > > On Tue, 2023-09-19 at 15:36 +0800, Kai-Heng Feng wrote: > > > On Mon, Sep 18, 2023 at 11:57=E2=80=AFPM srinivas pandruvada > > > wrote: > > > > > > > > Hi Kai-Heng, > > > > On Mon, 2023-09-18 at 09:17 +0800, Kai-Heng Feng wrote: > > > > > Hi Even, > > > > > > > > > > On Mon, Sep 18, 2023 at 8:33=E2=80=AFAM Xu, Even > > > > > wrote: > > > > > > > > > > > > Hi, Kai-Heng, > > > > > > > > > > > > I just got feedback, for testing EHL S5 wakeup feature, you > > > > > > need > > > > > > several steps to setup and access > > > > > > "https://portal.devicewise.com/things/browse" to trigger wake. > > > > > > But currently, our test account of this website are all out of > > > > > > data. > > > > > > So maybe you need double check with the team who required you > > > > > > preparing the patch for the verification. > > > > > > > > > > The patch is to solve the GPE refcount overflow, while > > > > > maintaining S5 > > > > > wakeup. I don't have any mean to test S5 wake. > > > > > > > > > The issue is not calling acpi_disable_gpe(). To reduce the scope of > > > > change can we just add that instead of a adding new callbacks. This > > > > way > > > > scope is reduced. > > > > > > This patch does exactly the same thing by letting PCI and ACPI handle > > > the PME and GPE. > > > Though the change seems to be bigger, it actually reduces the duped > > > code, while keep the S5 wakeup ability intact. > > It may be doing the same. But with long chain of calls without > > verification, I am not comfortable. > > This can be another patch by itself to use the framework. > > I agree. > > Let's change one thing at a time. > > > But you are targeting a fix for overflow issue, which is separate from > > the use of PCI/ACPI framework. > > Yes, let's fix the bug first and make things look nicer separately. Right, please use the fix from Srinivas and I'll send a separate patch to make things looks better. Kai-Heng