From: Dzmitry Sankouski <dsankouski@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Hans de Goede <hdegoede@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Purism Kernel Team <kernel@puri.sm>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v9 6/9] mfd: Add new driver for MAX77705 PMIC
Date: Tue, 3 Dec 2024 14:28:24 +0300 [thread overview]
Message-ID: <CABTCjFAZn5g_1ZR0+pN5JgpsikhhajsX0hdaDSvuT2Z-0Um71g@mail.gmail.com> (raw)
In-Reply-To: <59c27c5d-3db7-44da-b3ac-7b8e7c8b6f16@kernel.org>
пн, 2 дек. 2024 г. в 13:23, Krzysztof Kozlowski <krzk@kernel.org>:
>
> On 02/12/2024 10:47, Dzmitry Sankouski wrote:
> > Add the core MFD driver for max77705 PMIC. We define five sub-devices
> > for which the drivers will be added in subsequent patches.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> >
(...)
> > + /* Unmask interrupts from all blocks in interrupt source register */
> > + ret = regmap_update_bits(max77705->regmap,
> > + MAX77705_PMIC_REG_INTSRC_MASK,
> > + MAX77705_SRC_IRQ_ALL, (unsigned int)~MAX77705_SRC_IRQ_ALL);
>
>
> The need for cast comes from some compiler warning?
>
BIT macro creates a 64 bit constant value. When inverted,
it overruns 32 bit value, causing compiler to warn on conversion like
`warning: conversion from ‘long unsigned int’ to ‘unsigned int’`.
--
Best regards and thanks for review,
Dzmitry
next prev parent reply other threads:[~2024-12-03 11:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:47 [PATCH v9 0/9] Add support for Maxim Integrated MAX77705 PMIC Dzmitry Sankouski
2024-12-02 9:47 ` [PATCH v9 1/9] power: supply: add undervoltage health status property Dzmitry Sankouski
2024-12-02 9:47 ` [PATCH v9 2/9] dt-bindings: power: supply: max17042: add max77705 support Dzmitry Sankouski
2024-12-02 10:16 ` Krzysztof Kozlowski
2024-12-02 9:47 ` [PATCH v9 3/9] dt-bindings: power: supply: max17042: remove reg from required Dzmitry Sankouski
2024-12-02 10:18 ` Krzysztof Kozlowski
2024-12-02 9:47 ` [PATCH v9 4/9] dt-bindings: mfd: add maxim,max77705 Dzmitry Sankouski
2024-12-02 18:34 ` Jacek Anaszewski
2024-12-02 9:47 ` [PATCH v9 5/9] power: supply: max17042: add max77705 fuel gauge support Dzmitry Sankouski
2024-12-02 10:18 ` Krzysztof Kozlowski
2024-12-02 9:47 ` [PATCH v9 6/9] mfd: Add new driver for MAX77705 PMIC Dzmitry Sankouski
2024-12-02 10:23 ` Krzysztof Kozlowski
2024-12-03 11:28 ` Dzmitry Sankouski [this message]
2024-12-02 9:48 ` [PATCH v9 7/9] input: max77693: add max77705 haptic support Dzmitry Sankouski
2024-12-02 9:48 ` [PATCH v9 8/9] power: supply: max77705: Add charger driver for Maxim 77705 Dzmitry Sankouski
2024-12-02 10:28 ` Krzysztof Kozlowski
2024-12-02 9:48 ` [PATCH v9 9/9] leds: max77705: Add LEDs support Dzmitry Sankouski
2024-12-02 10:29 ` Krzysztof Kozlowski
2024-12-03 12:21 ` Dzmitry Sankouski
2024-12-05 16:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABTCjFAZn5g_1ZR0+pN5JgpsikhhajsX0hdaDSvuT2Z-0Um71g@mail.gmail.com \
--to=dsankouski@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kernel@puri.sm \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).