From: Andreas Bergmeier <abergmeier@gmx.net>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org,
USB mailing list <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Jiri Kosina <jikos@kernel.org>,
linux-leds@vger.kernel.org,
Nestor Lopez Casado <nlopezcasad@logitech.com>
Subject: Re: Litra Glow on Linux
Date: Thu, 10 Nov 2022 04:29:35 +0100 [thread overview]
Message-ID: <CABfF9mNbpTdAnChkZNKFed6C7n=Hyq-69rMUeDENE8ptLjJMSw@mail.gmail.com> (raw)
In-Reply-To: <CABfF9mO3SQZvkQGOC09H5s7EEd2UGhpE=GYB46g_zF3aEOVn=Q@mail.gmail.com>
On Wed, 9 Nov 2022 at 21:27, Andreas Bergmeier <abergmeier@gmx.net> wrote:
>
> Finally I have an environment where I can test my kernel code.
>
> On Mon, 31 Oct 2022 at 10:29, Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> > For identifying the GLOW device you should be adding an id in the
> > table of hid-logitech-hidpp, with a driver data that tells the driver
> > to look for 0x1990.
> >
> > >
> > > > - you need to add a hook in connect_event to register the led class
> > > > device that will hook on to the actual LED of the device
> Sadly my tests did not go very far. The code fails already when
> calling the `probe` callback (`hidpp_probe`).
> When it calls into `hidpp_root_get_protocol_version` it seems to
> receive `HIDPP_ERROR_RESOURCE_ERROR`.
> Which then leads to an error message: Device not connected
> Upon looking at `HIDPP_ERROR_RESOURCE_ERROR` (9) there is no
> documentation what it means in code.
> From a look into the docs it says that 9 is UNSUPPORTED error for 2.0
> devices. Thus I am wondering how the code knows
> that it is a problem with connectivity. Couldn't it also mean that the
> device is not supporting getting the protocol version?
> And why is protocol version only enforced for non unifying devices?
Also, looking into `supported_reports` turned out to be 2 (very long).
Inside of `hidpp_root_get_protocol_version` it does upgrade SHORT to
LONG if the former is not supported.
On a whim I then added upgrade of LONG to VERY LONG if the former is
not supported. Sadly, the results stayed the same.
next prev parent reply other threads:[~2022-11-10 3:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 15:17 Litra Glow on Linux Alan Stern
2022-10-19 15:48 ` Bastien Nocera
2022-10-19 15:49 ` Bastien Nocera
2022-10-19 19:40 ` Andreas Bergmeier
2022-10-20 18:22 ` Andreas Bergmeier
2022-10-22 12:42 ` Andreas Bergmeier
2022-10-25 7:46 ` Benjamin Tissoires
2022-10-26 20:49 ` Andreas Bergmeier
2022-10-27 9:45 ` Benjamin Tissoires
2022-10-29 8:21 ` Andreas Bergmeier
2022-10-31 9:30 ` Benjamin Tissoires
2022-11-04 7:45 ` Andreas Bergmeier
2022-11-04 11:40 ` Pavel Machek
2022-11-09 20:27 ` Andreas Bergmeier
2022-11-10 3:29 ` Andreas Bergmeier [this message]
2022-11-10 9:22 ` Benjamin Tissoires
2022-11-10 12:24 ` Andreas Bergmeier
2022-11-10 13:39 ` Benjamin Tissoires
2022-11-19 20:18 ` Andreas Bergmeier
2022-11-27 11:04 ` Andreas Bergmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABfF9mNbpTdAnChkZNKFed6C7n=Hyq-69rMUeDENE8ptLjJMSw@mail.gmail.com' \
--to=abergmeier@gmx.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).