* [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32
@ 2025-01-14 0:41 Vishnu Sankar
2025-03-04 20:13 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Vishnu Sankar @ 2025-01-14 0:41 UTC (permalink / raw)
To: jikos, bentiss, linux-input, linux-kernel
Cc: mpearson-lenovo, Vishnu Sankar, Vishnu Sankar, kernel test robot
Ensure that data is treated as __le32 instead of u32 before
applying le32_to_cpu.
This patch fixes the sparse warning "sparse: cast to restricted __le32".
Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
Signed-off-by: Vishnu Sankar <vsankar@lenovo.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501101635.qJrwAOwf-lkp@intel.com/
---
drivers/hid/hid-lenovo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index 4d00bc4d656e..0d9792750dcf 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -783,7 +783,7 @@ static int lenovo_raw_event(struct hid_device *hdev,
if (unlikely((hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB
|| hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB2)
&& size >= 3 && report->id == 0x03))
- return lenovo_raw_event_TP_X12_tab(hdev, le32_to_cpu(*(u32 *)data));
+ return lenovo_raw_event_TP_X12_tab(hdev, le32_to_cpu(*(__le32 *)data));
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32
2025-01-14 0:41 [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32 Vishnu Sankar
@ 2025-03-04 20:13 ` Jiri Kosina
2025-03-05 0:08 ` Vishnu Sankar
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2025-03-04 20:13 UTC (permalink / raw)
To: Vishnu Sankar
Cc: bentiss, linux-input, linux-kernel, mpearson-lenovo,
Vishnu Sankar, kernel test robot
On Tue, 14 Jan 2025, Vishnu Sankar wrote:
> Ensure that data is treated as __le32 instead of u32 before
> applying le32_to_cpu.
> This patch fixes the sparse warning "sparse: cast to restricted __le32".
>
> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
> Signed-off-by: Vishnu Sankar <vsankar@lenovo.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501101635.qJrwAOwf-lkp@intel.com/
Sorry for the delay, this fell in between cracks. Now applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32
2025-03-04 20:13 ` Jiri Kosina
@ 2025-03-05 0:08 ` Vishnu Sankar
0 siblings, 0 replies; 3+ messages in thread
From: Vishnu Sankar @ 2025-03-05 0:08 UTC (permalink / raw)
To: Jiri Kosina
Cc: bentiss, linux-input, linux-kernel, mpearson-lenovo,
Vishnu Sankar, kernel test robot
Thank you Jiri.
On Wed, Mar 5, 2025 at 5:13 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 14 Jan 2025, Vishnu Sankar wrote:
>
> > Ensure that data is treated as __le32 instead of u32 before
> > applying le32_to_cpu.
> > This patch fixes the sparse warning "sparse: cast to restricted __le32".
> >
> > Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
> > Signed-off-by: Vishnu Sankar <vsankar@lenovo.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202501101635.qJrwAOwf-lkp@intel.com/
>
> Sorry for the delay, this fell in between cracks. Now applied.
>
> --
> Jiri Kosina
> SUSE Labs
>
--
Regards,
Vishnu Sankar
+817015150407 (Japan)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-05 0:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-14 0:41 [PATCH] HID: lenovo: Fix to ensure the data as __le32 instead of u32 Vishnu Sankar
2025-03-04 20:13 ` Jiri Kosina
2025-03-05 0:08 ` Vishnu Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).