From: Rajat Jain <rajatja@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dmitry Torokhov <dtor@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Enrico Weigelt <info@metux.net>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stephen Boyd <swboyd@chromium.org>,
linux-input <linux-input@vger.kernel.org>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Furquan Shaikh <furquan@google.com>,
Duncan Laurie <dlaurie@google.com>,
Benson Leung <bleung@google.com>,
Zentaro Kavanagh <zentaro@google.com>,
Dominik Behr <dbehr@google.com>,
Rajat Jain <rajatxjain@gmail.com>
Subject: Re: [PATCH RESEND 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device
Date: Tue, 24 Mar 2020 05:20:14 -0700 [thread overview]
Message-ID: <CACK8Z6EHAv03XGXT0sY2H3TSjS4-yQtCscbHG_o1qCuG94zb6g@mail.gmail.com> (raw)
In-Reply-To: <20200324115059.GA2333340@kroah.com>
Hello,
On Tue, Mar 24, 2020 at 4:51 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Mar 23, 2020 at 04:45:01PM -0700, Rajat Jain wrote:
> > Attach the firmware node to the serio i8042 kbd device so that device
> > properties can be passed from the firmware.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
> > Change-Id: I36032f4bdee1dc52f26b57734068fd0ee7a6db0b
>
> Didn't you run checkpatch.pl on your patches which told you to remove
> all of these Change-Id: values?
My apologies. However I did run checkpatch.pl on my patches before
sending (also checked just now again) and it did not complain about
the Change-Id values in the commit log. Not sure if I'm running the
command incorrectly?
rajatja@rajat2:~/stock_kernel/linux$ ./scripts/checkpatch.pl
../patches/input_atkbd/v1/000*
-----------------------------------------------------------------------------------------
../patches/input_atkbd/v1/0001-input-serio-i8042-Attach-fwnode-to-serio-i8042-kbd-d.patch
-----------------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 28 lines checked
../patches/input_atkbd/v1/0001-input-serio-i8042-Attach-fwnode-to-serio-i8042-kbd-d.patch
has no obvious style problems and is ready for submission.
-----------------------------------------------------------------------------------------
../patches/input_atkbd/v1/0002-Input-atkbd-Expose-function-row-physical-map-to-user.patch
-----------------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 106 lines checked
../patches/input_atkbd/v1/0002-Input-atkbd-Expose-function-row-physical-map-to-user.patch
has no obvious style problems and is ready for submission.
......
<snip>
......
I will now resubmit the patches removing the Change-Id(s).
Thanks & Best Regards,
Rajat
>
> Please do so...
>
> greg k-h
prev parent reply other threads:[~2020-03-24 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 23:45 [PATCH RESEND 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device Rajat Jain
2020-03-23 23:45 ` [PATCH RESEND 2/5] Input: atkbd: Expose function row physical map to userspace Rajat Jain
2020-03-23 23:45 ` [PATCH RESEND 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap" Rajat Jain
2020-03-23 23:45 ` [PATCH RESEND 4/5] Input: atkbd: Receive and use physcode->keycode mapping from FW Rajat Jain
2020-03-23 23:45 ` [PATCH RESEND 5/5] dt-bindings: input/atkbd.txt: Add binding info for "keymap" property Rajat Jain
2020-03-24 11:50 ` [PATCH RESEND 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device Greg Kroah-Hartman
2020-03-24 12:20 ` Rajat Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACK8Z6EHAv03XGXT0sY2H3TSjS4-yQtCscbHG_o1qCuG94zb6g@mail.gmail.com \
--to=rajatja@google.com \
--cc=allison@lohutok.net \
--cc=bleung@google.com \
--cc=dbehr@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dlaurie@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@google.com \
--cc=furquan@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatxjain@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=zentaro@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).