Re: [PATCH v4 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap"

[Rajat Jain <rajatja@google.com>]

Hi,

On Fri, Apr 10, 2020 at 10:38 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote:
> > Create the documentation for the new introduced property, that
> > describes the function-row keys physical positions.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
> > ---
> > v4: Same as v3
> > v3: same as v2
> > v2: Remove the Change-Id from the commit log
> >
> >  .../devicetree/bindings/input/atkbd.txt       | 34 +++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt
> > new file mode 100644
> > index 0000000000000..816653eb8e98d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/atkbd.txt
> > @@ -0,0 +1,34 @@
> > +Device tree bindings for AT / PS2 keyboard device
> > +
> > +Optional properties:
> > +
> > +     function-row-physmap:
> > +                     An ordered array of the physical codes for the function
> > +                     row keys. Arranged in order from left to right.
>
> A single optional property doesn't constitute a DT binding.
>
> > +
> > +Example:
> > +
> > +     This is a sample ACPI _DSD node describing the property:
>
> Neither does this ACPI stuff.

I assume this means a nack to the documentation patches.

Dmitry, can you apply the other patches in the series?

Thanks,

Rajat

>
> Rob